Skip to content

Move away from setup.py as its deprecated#179

Merged
alourie merged 6 commits intomainfrom
use-new-build-system
Aug 20, 2025
Merged

Move away from setup.py as its deprecated#179
alourie merged 6 commits intomainfrom
use-new-build-system

Conversation

@chestm007
Copy link
Copy Markdown
Contributor

Need to look at tox.ini and update github workflows

@alourie
Copy link
Copy Markdown
Contributor

alourie commented May 15, 2025

yea this looks good but we need to see if CI needs updating, specifically for version detection.

@chestm007 chestm007 requested a review from kgreav May 15, 2025 11:27
@chestm007
Copy link
Copy Markdown
Contributor Author

It should still build, but CI certainly needs updating to match

@chestm007 chestm007 force-pushed the use-new-build-system branch 2 times, most recently from 9c80835 to aaaaea9 Compare May 17, 2025 12:47
@chestm007
Copy link
Copy Markdown
Contributor Author

Tox.ini reworked and functional.

Test included for python 3.12 - should we add that to the classifiers?

@kgreav does the github workflow need to be updated as part of this?

@chestm007 chestm007 force-pushed the use-new-build-system branch from 60d1210 to 6ea6108 Compare May 21, 2025 07:10
@kgreav
Copy link
Copy Markdown
Member

kgreav commented May 26, 2025

I think workflow should be fine - you've got an error in your tests?

Traceback:
85
/usr/local/lib/python3.9/importlib/__init__.py:127: in import_module
86
    return _bootstrap._gcd_import(name[level:], package, level)
87
test/cim/iec61970/base/core/test_site.py:8: in <module>
88
    from build.lib.zepben.evolve.services.network.tracing.networktrace.operators.network_state_operators import NetworkStateOperators
89
E   ModuleNotFoundError: No module named 'build'

not sure what you're importing from here - should just be from zepben.evolve import NetworkStateOperators,
the tests should pretty much be able to export everything directly from zepben.evolve - i.e the tests interact with the source like they are external to the source, if that makes sense.

@alourie
Copy link
Copy Markdown
Contributor

alourie commented May 26, 2025

Please don't merge this until we figure out the proper way to update the CI utils. It's going to break the way we update python versions, so this should be in sync either with the flows providing the correct file to parse (ie pyproject.toml) or in sync with all other python-based projects, which should deprecate setup.py as well.

@kgreav
Copy link
Copy Markdown
Member

kgreav commented May 27, 2025

Yep you're right - there's only this repo and ewb-sdk-examples-python actually using the workflows, so we can probably just update them, merge this, and then fix ewb-sdk-examples python

@chestm007 chestm007 force-pushed the use-new-build-system branch 2 times, most recently from b20a105 to 7a98136 Compare June 4, 2025 10:41
@charlta charlta marked this pull request as draft June 4, 2025 11:05
@charlta
Copy link
Copy Markdown
Member

charlta commented Jun 4, 2025

marked as draft till build checks etc pass and CI work is down to allow that to happen

@chestm007 chestm007 force-pushed the use-new-build-system branch from 7a98136 to 78c52b6 Compare June 19, 2025 10:40
@chestm007 chestm007 force-pushed the use-new-build-system branch 3 times, most recently from 93fde89 to 3b3ceaa Compare July 31, 2025 05:15
@chestm007 chestm007 force-pushed the use-new-build-system branch from 3b3ceaa to 9672048 Compare August 20, 2025 05:06
@chestm007 chestm007 marked this pull request as ready for review August 20, 2025 14:03
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
@chestm007 chestm007 force-pushed the use-new-build-system branch from 9672048 to 19a3e84 Compare August 20, 2025 14:44
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
Copy link
Copy Markdown
Contributor

@alourie alourie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go

@alourie alourie merged commit 1b15794 into main Aug 20, 2025
4 checks passed
@alourie alourie deleted the use-new-build-system branch August 20, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants