Enhance reusable Zsh CI workflow with fixes and improvements#428
Merged
Conversation
Agent-Logs-Url: https://github.com/z-shell/.github/sessions/049d7344-1f68-482a-a7df-c757da5c5a75 Co-authored-by: ss-o <59910950+ss-o@users.noreply.github.com>
Agent-Logs-Url: https://github.com/z-shell/.github/sessions/049d7344-1f68-482a-a7df-c757da5c5a75 Co-authored-by: ss-o <59910950+ss-o@users.noreply.github.com>
Agent-Logs-Url: https://github.com/z-shell/.github/sessions/049d7344-1f68-482a-a7df-c757da5c5a75 Co-authored-by: ss-o <59910950+ss-o@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Sall <59910950+ss-o@users.noreply.github.com>
Agent-Logs-Url: https://github.com/z-shell/.github/sessions/ce3b120c-fbcc-4575-88e5-9b02d5b62f8b Co-authored-by: ss-o <59910950+ss-o@users.noreply.github.com>
Agent-Logs-Url: https://github.com/z-shell/.github/sessions/ce3b120c-fbcc-4575-88e5-9b02d5b62f8b Co-authored-by: ss-o <59910950+ss-o@users.noreply.github.com>
Agent-Logs-Url: https://github.com/z-shell/.github/sessions/ce3b120c-fbcc-4575-88e5-9b02d5b62f8b Co-authored-by: ss-o <59910950+ss-o@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to improve cross-repo reuse for Zsh CI by introducing a reusable workflow and making the existing zsh-n workflow callable via workflow_call.
Changes:
- Added
workflow_calltrigger support to.github/workflows/zsh-n.yml. - Added a new reusable workflow
.github/workflows/reusable-zsh-ci.ymlto runzsh -nandzcompileacross all*.zshfiles.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
.github/workflows/zsh-n.yml |
Adds workflow_call so the existing per-file matrix syntax/compile workflow can be invoked as a reusable workflow. |
.github/workflows/reusable-zsh-ci.yml |
Introduces a new reusable workflow that discovers *.zsh files, runs zsh -n, and compiles them with zcompile. |
- Unquote `on:` for consistency with other workflows
- Add workflow-level `permissions: {}` and job-level `permissions: contents: read`
- Add `concurrency:` block matching other repo workflows
- Pin actions/checkout to SHA de0fac2e (v6.0.2)
- Use apt-get consistently (drop bare `apt update`)
- Prune `.git/` in both find commands alongside `doc/`
- Change exit 1 on no .zsh files to no-op exit 0
Agent-Logs-Url: https://github.com/z-shell/.github/sessions/ba89a619-772a-4b3e-9e6c-57c215be60dc
Co-authored-by: ss-o <59910950+ss-o@users.noreply.github.com>
zsh-ci.yml already provides the same functionality (zsh -n + optional zcompile) with more robust behavior: zsh-version/run-zcompile inputs, GitHub error annotations, and proper error accumulation. Addresses review comment about overlap with existing zsh-ci.yml workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor update to the Zsh GitHub Actions workflow configuration. The workflow now supports being triggered by the
workflow_callevent, enabling it to be invoked from other workflows.