Loading workfow fixes and improvements#130
Open
jakubjezek001 wants to merge 5 commits into
Open
Conversation
- Sort imports alphabetically within groups - Add docstring to ClipLoader.load_clip with Args and Raises - Convert RuntimeError to LoadError with full traceback - Fix layer name resolution to check sourceName fallback
jakubjezek001
added
the
type: enhancement
7 tasks
jakubjezek001
commented
Jun 24, 2026
| ) -> None: | ||
| layer_uid = xml_track_data.get("uid") | ||
| name_obj = ( | ||
| xml_track_data.find("name") |
Member
Author
There was a problem hiding this comment.
This is fix for case where the video file is supported but for some reason Flame is generating different kind of XML without the Name tag inside..
jakubjezek001
commented
Jun 24, 2026
Comment on lines
+789
to
+799
| except RuntimeError as exc: | ||
| import traceback | ||
| trcbck_txt = "".join( | ||
| traceback.format_exception( | ||
| type(exc), exc, exc.__traceback__ | ||
| ) | ||
| ) | ||
| msg = ( | ||
| "Unsupported Input: " | ||
| f"Flame does not support incoming media path {path} \n\n" | ||
| f"{trcbck_txt}" |
Member
Author
There was a problem hiding this comment.
it is much better to use Loader native popup then the Flame one. Actually the Flame native is hidden under the Loader window and it is quite UX confusing.
iLLiCiTiT
reviewed
Jun 24, 2026
| self.log = logger | ||
|
|
||
| # could be windows path | ||
| path = path.replace("\\", "/") |
Member
There was a problem hiding this comment.
I don't think this is safe, \ can be used as an escape character on linux or macos. Where would the path come from?
Member
Author
There was a problem hiding this comment.
from represetnation files
iLLiCiTiT
reviewed
Jun 24, 2026
jakubjezek001
commented
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Testing notes: