YN-0022 Consolidate LoadClip and LoadClipBatch#123
Conversation
There was a problem hiding this comment.
Pull request overview
Consolidates LoadClip and LoadClipBatch behavior by moving shared loader logic into the ClipLoader base class, aiming to fix version/representation edge cases and reduce duplication.
Changes:
- Move common
product_base_types/representations/extensionsand clip-loading logic intoclient/ayon_flame/api/plugin.py::ClipLoader. - Update
LoadClipandLoadClipBatchto rely on the consolidated base implementation and simplify reel retrieval logic. - Add OpenClip “current version” setter guard and adjust clip naming format-data handling.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| client/ayon_flame/plugins/load/load_clip_batch.py | Switches to base ClipLoader defaults and customizes clip-name format data with batch name. |
| client/ayon_flame/plugins/load/load_clip.py | Switches to base ClipLoader defaults and refactors reel group/reel creation logic. |
| client/ayon_flame/api/plugin.py | Centralizes clip loading/version aggregation logic in ClipLoader and adds OpenClip current-version handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…on-flame into bugfix/YN-0022_fix_clip_loaders
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…20_batchgroup_loader_publisher
…nhancement/YN-0620_batchgroup_output_publisher
…nhancements/cleanup_repo
…nhancement/YN-0620_batchgroup_output_publisher
…nhancements/cleanup_repo
Chore: Reduce and remove dead code
…put_publisher YN-0620 Batch "Write File" creator and publisher
…der_publisher YN-0620 - Batch creator/publisher/loader + Improve batch_utils module
BigRoy
left a comment
There was a problem hiding this comment.
Should've been approved. I'm hearing this has been tested via some other PRs 🤔
jakubjezek001
left a comment
There was a problem hiding this comment.
Tried LoadClip and LoadClipBatch, both with the same result. I have noticed that it is only happening on certain product versions. I will investigate more if this is not caused by my setup or it could be effecting also productions:
Traceback (most recent call last):
File "/Users/jakub/CODE/__YNPUT/ayon-core/client/ayon_core/tools/loader/models/actions.py", line 1005, in _load_representations_by_loader
load_with_repre_context(
File "/Users/jakub/CODE/__YNPUT/ayon-core/client/ayon_core/pipeline/load/utils.py", line 327, in load_with_repre_context
return loader.load(repre_context, name, namespace, options)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/jakub/CODE/__YNPUT/ayon-core/client/ayon_core/pipeline/load/plugins.py", line 430, in wrapped_method
result = original_method(self, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/jakub/CODE/__YNPUT/ayon-flame/client/ayon_flame/plugins/load/load_clip_batch.py", line 30, in load
return super().load(context, name, namespace, options)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/jakub/CODE/__YNPUT/ayon-flame/client/ayon_flame/api/plugin.py", line 785, in load
clip_solver.add_feed(
File "/Users/jakub/CODE/__YNPUT/ayon-flame/client/ayon_flame/api/plugin.py", line 897, in add_feed
self._create_new_open_clip(
File "/Users/jakub/CODE/__YNPUT/ayon-flame/client/ayon_flame/api/plugin.py", line 933, in _create_new_open_clip
self._rename_track_name(
File "/Users/jakub/CODE/__YNPUT/ayon-flame/client/ayon_flame/api/plugin.py", line 1001, in _rename_track_name
name_obj.text = StringTemplate(
^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'text'
|
So I can confirm that this will be effecting productions which are for example publishing from Windows Nuke and want to load it into linux or MacOS Flame. It might be perhaps unrelated for this PR and I will make a bugfix PR. #130 |
Changelog Description
fixes: #114 and #113
Consolidate
LoadClipandLoadClipBatch:AttributeErrorformatting data bug with batch groupsxr)NoneTypeAdditional review information
Tested on Flame 2026.2 / macOs
Testing notes: