Skip to content

fix: handle Docker named volume for .venv in dev entrypoint #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xprilion merged 4 commits into from
Apr 30, 2026
Merged

fix: handle Docker named volume for .venv in dev entrypoint #36

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f7e86b
fix: handle Docker named volume for .venv in dev entrypoint
silasly Apr 30, 2026
fe25d7f
Potential fix for pull request finding
xprilion Apr 30, 2026
356894f
Potential fix for pull request finding
xprilion Apr 30, 2026
d3754df
Merge branch 'main' into fix/dockerfile-dev-venv-volume
xprilion Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions Dockerfile.dev
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,21 @@ set -e
# Check if the venv has a working Python (catches cross-platform mismatch)
if ! /app/backend/.venv/bin/python -c "import sys" 2>/dev/null; then
echo "[dev-entrypoint] Installing dependencies (venv missing or incompatible)..."
rm -rf /app/backend/.venv
cd /app/backend && uv sync && uv pip install "watchdog[watchmedo]"
# Docker named volumes can't always be rm -rf'd, so try rm first and warn if it fails
rm_err_file="$(mktemp)"
if ! rm -rf /app/backend/.venv 2>"$rm_err_file"; then
echo "[dev-entrypoint] Warning: failed to remove /app/backend/.venv; continuing with 'uv venv --clear'." >&2
cat "$rm_err_file" >&2
fi
rm -f "$rm_err_file"
cd /app/backend && uv venv --clear && uv sync && uv pip install "watchdog[watchmedo]"
echo "[dev-entrypoint] Dependencies installed."
else
# Venv works — run uv sync to pick up any new/changed dependencies
echo "[dev-entrypoint] Syncing dependencies..."
cd /app/backend && uv sync --quiet 2>/dev/null || true
if ! (cd /app/backend && uv sync --quiet); then
echo "[dev-entrypoint] Warning: dependency sync failed; continuing with existing environment." >&2
fi
# Ensure watchmedo is there too
if ! command -v watchmedo >/dev/null 2>&1; then
cd /app/backend && uv pip install "watchdog[watchmedo]"
Expand Down