Wrap bare error returns in login package

internal/login/errors_test.go

@@ -0,0 +1,14 @@
+package login
+
+import (
+	"errors"
+	"fmt"
+	"testing"
+)
+
+func TestNoRemoteDebugEndpointIsWrappable(t *testing.T) {
+	wrapped := fmt.Errorf("firstAvailableRemoteDebugEndpoint: %w", errNoRemoteDebugEndpoint)
+	if !errors.Is(wrapped, errNoRemoteDebugEndpoint) {
+		t.Fatalf("errors.Is should report wrapped error as errNoRemoteDebugEndpoint, got false")
+	}
+}

internal/login/login.go

@@ -222,7 +222,7 @@
 
 	if provider == session.ProviderDelio {
 		if !hasDelioAuthCookie(cookieHeader) {
 			return nil, fmt.Errorf("Delio auth cookies not detected — open a logged-in Delio page or sign in in the opened browser window and wait for the session to load")
 		}
 	} else if accessToken == "" {
 		return nil, fmt.Errorf("Frisco access token not detected — open a logged-in Frisco page or sign in and navigate to cart/account to trigger API requests")
@@ -496,13 +496,13 @@
 
 func copyBrowserProfileSnapshot(srcUserData, dstUserData, profileDirectory string) error {
 	if err := os.MkdirAll(dstUserData, 0o700); err != nil {
-		return err
+		return fmt.Errorf("create snapshot user data dir: %w", err)
 	}
 	localStateSrc := filepath.Join(srcUserData, "Local State")
 	localStateDst := filepath.Join(dstUserData, "Local State")
 	if _, err := os.Stat(localStateSrc); err == nil {
 		if err := copyFile(localStateSrc, localStateDst); err != nil {
-			return err
+			return fmt.Errorf("copy browser Local State: %w", err)
 		}
 	}
 	srcProfile := filepath.Join(srcUserData, profileDirectory)
@@ -557,23 +557,23 @@
 func copyFile(src, dst string) error {
 	in, err := os.Open(src)
 	if err != nil {
-		return err
+		return fmt.Errorf("open source file %s: %w", src, err)
 	}
 	defer func() { _ = in.Close() }()
 	info, err := in.Stat()
 	if err != nil {
-		return err
+		return fmt.Errorf("stat source file %s: %w", src, err)
 	}
 	if err := os.MkdirAll(filepath.Dir(dst), 0o700); err != nil {
-		return err
+		return fmt.Errorf("create destination dir for %s: %w", dst, err)
 	}
 	out, err := os.OpenFile(dst, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, info.Mode())
 	if err != nil {
-		return err
+		return fmt.Errorf("create destination file %s: %w", dst, err)
 	}
 	defer func() { _ = out.Close() }()
 	if _, err := io.Copy(out, in); err != nil {
-		return err
+		return fmt.Errorf("copy file contents to %s: %w", dst, err)
 	}
 	return out.Chmod(info.Mode())
 }

internal/login/remote_debug.go

@@ -21,25 +21,25 @@
 	"github.com/wydrox/martmart-cli/internal/session"
 )
 
 type remoteDebugVersion struct {
 	Browser              string `json:"Browser"`
 	WebSocketDebuggerURL string `json:"webSocketDebuggerUrl"`
 }
 
 type remoteDebugTarget struct {
 	ID    string `json:"id"`
 	Type  string `json:"type"`
 	URL   string `json:"url"`
 	Title string `json:"title"`
 }
 
 type remoteDebugDelioCapture struct {
 	Headers      map[string]string
 	CookieHeader string
 	UserID       string
 }
 
 type remoteDebugFriscoCapture struct {
 	CookieHeader string
 	AccessToken  string
 	RefreshToken string
@@ -216,7 +216,7 @@
 	client := &http.Client{Timeout: 2 * time.Second}
 	resp, err := client.Get(rawURL)
 	if err != nil {
-		return err
+		return fmt.Errorf("GET %s: %w", rawURL, err)
 	}
 	defer func() { _ = resp.Body.Close() }()
 	if resp.StatusCode < 200 || resp.StatusCode >= 300 {