Wrap bare error returns in login package#6
Open
wydrox wants to merge 1 commit into
Open
Conversation
Add fmt.Errorf("context: %w", err) wrapping around exec/file-io/HTTP
bare `return err` paths in copyFile, copyBrowserProfileSnapshot, and
remoteDebugGetJSON so error traces identify the failing operation while
remaining compatible with errors.Is/As.
Walk-callback error bubble-ups, already-wrapped error passthroughs, and
chromedp ActionFunc returns are left unwrapped per idiomatic Go.
Audit notes:
- No %v error wrapping was found in this package (spec called for
%v -> %w conversion; it is a no-op here).
- All errors.New calls use static strings (no dynamic context); left
untouched per spec.
- Add errors_test.go asserting errNoRemoteDebugEndpoint remains
errors.Is-compatible when wrapped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
return errincopyFile,copyBrowserProfileSnapshot, andremoteDebugGetJSONwithfmt.Errorf("context: %w", err)so error traces identify the failing operation and remain compatible witherrors.Is/errors.As.ActionFuncreturns unwrapped per idiomatic Go.internal/login/errors_test.goassertingerrNoRemoteDebugEndpointstayserrors.Is-compatible after wrapping.Audit notes
: %verror wrapping was found in this package; the%v->%wconversion is a no-op here.errors.Newcalls in the package use static strings (no dynamic context); left untouched per spec.Test plan
go vet ./...go test ./... -racego build -o bin/martmart ./cmd/martmartGOOS=linux go build -o /tmp/martmart-linux ./cmd/martmart(cross-compile check)./bin/martmart --helpand./bin/martmart config showgo test ./internal/login/... -v