Add the ability to Import a PathWeaver Waypoint file#3181
Closed
jasondaming wants to merge 4 commits intowpilibsuite:mainfrom
Closed
Add the ability to Import a PathWeaver Waypoint file#3181jasondaming wants to merge 4 commits intowpilibsuite:mainfrom
jasondaming wants to merge 4 commits intowpilibsuite:mainfrom
Conversation
prateekma
reviewed
Feb 16, 2021
Starlight220
requested changes
Feb 17, 2021
Member
Starlight220
left a comment
Starlight220
left a comment
There was a problem hiding this comment.
Why not use the Jackson CSV reader and be done with it? We have Jackson available.
Member
Author
|
See the Discord Chat. We do not have Jackson CSV stuff available. |
Member
|
Looks like this mainly needs some formatting fixes? Probably should merge the latest main too. |
Member
|
OBE as we're planning on going to JSON format instead of CSV. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3180
Linked to PathWeaver PR #206:
wpilibsuite/PathWeaver#206