-
Notifications
You must be signed in to change notification settings - Fork 36
feat: share public link - WPB-20915 #4032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
edf6b3d
WPB-20915: added Item menu entry "share"
WilhelmOks d25913c
WPB-20915: navigating to share link view with dummy buttons
WilhelmOks 9aa5e67
WPB-20915: navigation to subviews password and expiration
WilhelmOks 05e6b00
Merge branch 'develop' into feat/WPB-20915-share-public-link
WilhelmOks 1fd2abd
WPB-20915: tint color
WilhelmOks ca55345
WPB-20915: files for password view
WilhelmOks 53928c3
WPB-20915: toolbars
WilhelmOks 29d7a54
WPB-20915: alerts
WilhelmOks 0eb18aa
WPB-20915: description and toggle
WilhelmOks 1be3cc0
WPB-20915: opening sheet also from AllFiles
WilhelmOks 9d1634f
WPB-20915: -
WilhelmOks 8f1ac8b
Merge branch 'develop' into feat/WPB-20915-share-public-link
WilhelmOks 3209364
WPB-20915: generate-password button
WilhelmOks bf1787f
WPB-20915: buttons for copy password and change password
WilhelmOks 9b88fa5
WPB-20915: password input field
WilhelmOks b202a41
WPB-20915: accessibility, pasteboard, refactoring
WilhelmOks 793d656
WPB-20915: some ViewModel logic and handing back data to the previous…
WilhelmOks 0f938af
WPB-20915: refactoring to one ViewModel for 3 Views
WilhelmOks 09fbb85
Revert "WPB-20915: refactoring to one ViewModel for 3 Views"
WilhelmOks 035ff40
WPB-20915: comments
WilhelmOks 7205d5c
Merge branch 'develop' into feat/WPB-20915-share-public-link
WilhelmOks 8c4e590
WPB-20915: added publicLinkId to FilesViewItem
WilhelmOks 8b6e131
WPB-20915: use case for getting link data
WilhelmOks f8c481c
WPB-20915: comment
WilhelmOks 1d41a1c
Merge branch 'develop' into feat/WPB-20915-share-public-link
WilhelmOks 589fd9d
new ExpirationDatePickerView
OlivellaO 1ece39d
add logic to show date in the past
OlivellaO d65d07c
code format
OlivellaO 56bc613
update shared link view
OlivellaO be2ea5e
Provide correct data in WireCellsPublicLink
samwyndham 908f109
Fix link URL
samwyndham 1c0d014
Fix anf implement remaining rest use cases
samwyndham 4ee9945
Hook up ShareLinkView & ExpirationDatePickerView
samwyndham d9c9154
delete some debug code
samwyndham 171e566
Merge branch 'develop' into feat/WPB-20915-share-public-link
samwyndham e42aaa4
Fix tests
samwyndham 5f50a8e
Include requires password in state
samwyndham d17c846
Add some to comments
samwyndham 49f6ef4
add keychain use cases, related logic, fix some TODOs
jullianm 6c1d5f3
Merge branch 'develop' into feat/WPB-20915-share-public-link
jullianm 36e54aa
handle errors, loading state, clean up code, UI adjustments
jullianm 7239387
lint and format
jullianm e42a87a
UI adjustments relates to link expiration
jullianm 46336f5
add snapshot tests
jullianm 49e5c7c
Merge branch 'develop' into feat/WPB-20915-share-public-link
jullianm ab739ec
update snapshots
jullianm 8cf417f
Merge branch 'develop' into feat/WPB-20915-share-public-link
jullianm b2fbcaf
Merge branch 'develop' into feat/WPB-20915-share-public-link
jullianm 9a12ac2
Merge branch 'develop' into feat/WPB-20915-share-public-link
jullianm 5171483
add missing check
jullianm 767f709
Merge branch 'develop' into feat/WPB-20915-share-public-link
jullianm 7749b7f
lint and format
jullianm 8783373
Merge branch 'develop' into feat/WPB-20915-share-public-link
jullianm 726d907
fix PR comments
jullianm 23aab97
lint and format
jullianm c947ee1
Merge branch 'develop' into feat/WPB-20915-share-public-link
jullianm 90f599d
lint and format
jullianm 27bdffc
Merge branch 'develop' into feat/WPB-20915-share-public-link
jullianm fb192a2
inject Calendar component
jullianm b312491
Merge branch 'develop' into feat/WPB-20915-share-public-link
jullianm 884f17a
comment out failing snapshot test (added TODO)
jullianm 7cd564b
Merge branch 'feat/WPB-20915-share-public-link' of ssh://github.com/w…
jullianm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
...s/WireMessagingDomain/WireCells/Protocols/WireCellsGetPublicLinkDataUseCaseProtocol.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| // | ||
| // Wire | ||
| // Copyright (C) 2026 Wire Swiss GmbH | ||
| // | ||
| // This program is free software: you can redistribute it and/or modify | ||
| // it under the terms of the GNU General Public License as published by | ||
| // the Free Software Foundation, either version 3 of the License, or | ||
| // (at your option) any later version. | ||
| // | ||
| // This program is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| // GNU General Public License for more details. | ||
| // | ||
| // You should have received a copy of the GNU General Public License | ||
| // along with this program. If not, see http://www.gnu.org/licenses/. | ||
| // | ||
|
|
||
| public protocol WireCellsGetPublicLinkDataUseCaseProtocol: Sendable { | ||
| func invoke(linkID: String) async throws -> WireCellsPublicLink | ||
| } |
23 changes: 23 additions & 0 deletions
23
...s/WireMessagingDomain/WireCells/UseCases/Keychain/Helpers/Keychain+WireCellsService.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| // | ||
| // Wire | ||
| // Copyright (C) 2026 Wire Swiss GmbH | ||
| // | ||
| // This program is free software: you can redistribute it and/or modify | ||
| // it under the terms of the GNU General Public License as published by | ||
| // the Free Software Foundation, either version 3 of the License, or | ||
| // (at your option) any later version. | ||
| // | ||
| // This program is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| // GNU General Public License for more details. | ||
| // | ||
| // You should have received a copy of the GNU General Public License | ||
| // along with this program. If not, see http://www.gnu.org/licenses/. | ||
| // | ||
|
|
||
| import WireFoundation | ||
|
|
||
| extension Keychain { | ||
| static let wireDriveSharedLinkPasswordService = "wire-drive-shared-link-password" | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.