feat: share public link - WPB-20915 #4032
Open
+2,697
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # WireMessaging/Sources/WireMessagingUI/WireCells/Components/Files/FilesItemViewModel.swift # WireMessaging/Sources/WireMessagingUI/WireCells/Components/Files/FilesPreviewHelpers.swift # WireMessaging/Sources/WireMessagingUI/WireCells/Components/Files/FilesViewModel.swift # WireMessaging/Tests/WireMessagingTests/WireCells/UITests/Components/Files/FilesViewTests.swift
This reverts commit 0f938af.
# Conflicts: # WireMessaging/Sources/WireMessagingUI/WireCells/Components/Files/FilesItemViewModel.swift # WireMessaging/Sources/WireMessagingUI/WireCells/Components/Files/FilesView.swift # WireMessaging/Sources/WireMessagingUI/WireCells/Components/Files/FilesViewModel.swift
# Conflicts: # WireMessaging/Sources/WireMessagingAssembly/WireMessagingFactory.swift # WireMessaging/Sources/WireMessagingData/WireCells/NodesAPI/NodesAPI.swift # WireMessaging/Sources/WireMessagingData/WireCells/NodesAPI/RestAPI.swift # WireMessaging/Sources/WireMessagingUI/WireCells/Components/Files/FilesPreviewHelpers.swift # WireMessaging/Sources/WireMessagingUI/WireCells/Components/Files/FilesViewContainer.swift # WireMessaging/Sources/WireMessagingUI/WireCells/Components/Files/FilesViewItemView.swift # WireMessaging/Sources/WireMessagingUI/WireCells/Components/Files/FilesViewModel.swift # WireMessaging/Sources/WireMessagingUI/WireCells/Components/Files/RecycleBinContainer.swift # WireMessaging/Sources/WireMessagingUI/WireCells/Components/Tags/TagsEditView.swift
jullianm
requested review from
a team,
David-Henner and
caldrian
and removed request for
a team
Contributor
Test Results290 tests 289 ✅ 49s ⏱️ For more details on these failures, see this check. Results for commit 8cf417f. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR introduces the ability to the user to share a public link w or w/o a password / expiration date.
After enabling a public link for a file, user can share the password or the link.
The public link (as well as the password / exp date) can be enabled/disabled on the fly.
Simulator.Screen.Recording.-.Snapshots.-.2025-12-18.at.14.46.00.mov
Testing
go to a File in the list (in a wire cells enabled conv), click on Share, it opens up a flow where we can:
the shared link should require password if password was set and should no longer be visible if date is expired.
check video for more details on how the feature can be tested
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: