Skip to content

fix(react-router): exclude same-page hash anchors from NavLink #5750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vianmora wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

fix(react-router): exclude same-page hash anchors from NavLink #5750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/sdk-components-react-router/src/link.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,12 @@ export const Link = forwardRef<HTMLAnchorElement, Props>((props, ref) => {
// remix appends ?index in runtime but not in ssr
href === "" ||
href.startsWith("?") ||
(href.startsWith("/") && href.startsWith(assetBaseUrl) === false)
(href.startsWith("/") &&
href.startsWith(assetBaseUrl) === false &&
// Same-page hash anchors (e.g. /#section) share pathname "/" with every
// root page — NavLink would mark them all as aria-current="page" in SSR.
// Use a plain anchor instead; hash navigation doesn't cross page boundaries.
href.startsWith("/#") === false)
) {
// In the future, we will switch to the :local-link pseudo-class (https://developer.mozilla.org/en-US/docs/Web/CSS/:local-link). (aria-current="page" is used now)
// Therefore, we decided to use end={true} (exact route matching) for all links to facilitate easier migration.
Expand Down
Loading