fix(react-router): exclude same-page hash anchors from NavLink#5750
Open
vianmora wants to merge 1 commit into
Open
fix(react-router): exclude same-page hash anchors from NavLink#5750vianmora wants to merge 1 commit into
vianmora wants to merge 1 commit into
Conversation
Links like /#section share pathname "/" with the root page, so React Router's NavLink marks them all as aria-current="page" in SSR. This causes [aria-current=page] styles to apply to every hash anchor on the homepage, making hover/active indicators always visible. Plain <a> is correct here since hash anchors don't cross page boundaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Links like
/#sectionshare pathname/with the root page. Withend={true}, React Router'sNavLinkstill considers/to match/regardless of the hash — so every/#sectionlink on the homepage getsaria-current="page"in SSR.This causes any CSS rule targeting
[aria-current=page](e.g. active nav indicator, underline, color) to apply permanently to all hash anchors on the home page, instead of only the current page link.Fix
Exclude
hrefvalues starting with/#from theNavLinkbranch and fall through to a plain<a>. Hash anchors don't navigate between pages so they should never receivearia-current="page".Test
/link should havearia-current="page", not/#sectionlinks/about): no hash anchor links should be marked active@kof if you want to review this one