Skip to content

ci: run site build on PRs #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avivkeller merged 1 commit into from
Jun 18, 2026
+33 −0
Merged

ci: run site build on PRs #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,36 @@ jobs:

- name: Lint & Format
run: npm run lint && npm run format:check

build:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

- name: Setup Node.js
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
with:
node-version: lts/*
cache: 'npm'

- name: Install dependencies
run: npm ci

- name: Cache fetched webpack sources
uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0
with:
path: .cache/webpack
key: webpack-sources-${{ hashFiles('versions.json') }}

- name: Build site
run: npm run build
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Upload build output
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
with:
name: site
path: out
retention-days: 7
Comment on lines +60 to +65

@bjohansebas bjohansebas Jun 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why upload the site?

@ryzrr ryzrr Jun 18, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I introduced it because it will be consumed by the playwright / Lighthouse , so instead of rebuilding we can directly use it , considering both are in the same ci

@avivkeller avivkeller Jun 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Playwright / Lighthouse can use Vercel, fwiw.

I do like that we upload, so that a downloadable version is available.

Loading