Skip to content

ci: run site build on PRs#146

Merged
avivkeller merged 1 commit into
mainfrom
ci/build-in-ci
Jun 18, 2026
Merged

ci: run site build on PRs#146
avivkeller merged 1 commit into
mainfrom
ci/build-in-ci

Conversation

@ryzrr

@ryzrr ryzrr commented Jun 18, 2026

Copy link
Copy Markdown
Member

Summary

Adds the CI Build to run on every PR.

What kind of change does this PR introduce?
CI Addition

Did you add tests for your changes?
Not Needed.

Does this PR introduce a breaking change?
No

If relevant, what needs to be documented once your changes are merged or what have you already documented?

None
Use of AI

No

@vercel

vercel Bot commented Jun 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
webpack-doc-kit Ready Ready Preview, Comment Jun 18, 2026 4:43pm

Request Review

@avivkeller avivkeller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment thread .github/workflows/ci.yml
Comment on lines +60 to +65
- name: Upload build output
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
with:
name: site
path: out
retention-days: 7

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why upload the site?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I introduced it because it will be consumed by the playwright / Lighthouse , so instead of rebuilding we can directly use it , considering both are in the same ci

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Playwright / Lighthouse can use Vercel, fwiw.

I do like that we upload, so that a downloadable version is available.

@avivkeller avivkeller merged commit d548d8a into main Jun 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants