Extended library with Information about "responses" w/ type information#163
Extended library with Information about "responses" w/ type information#163bradleat wants to merge 9 commits intowcandillon:masterfrom
Conversation
Adding in Individumm's changes which add the response code into the mix
|
Also added optional parameters to typescript definitions |
|
@bradleat: Is there an example I could look at? |
|
@wcandillon apologies. Is the example still needed? What would you want to see? A source spec and a template that makes use of the new variables? |
| var property = convertType(propertyType); | ||
| property.name = propertyName; | ||
| typespec.properties.push(property); | ||
| // see if property is required |
There was a problem hiding this comment.
This change and the one in type.mustache seems to be unrelated to the other change with the response, is my understanding correct?
There was a problem hiding this comment.
It is. I think you have the correct understanding.
One goal was to give in response type information to the templates.
The other goal was to add the information about optional properties
|
@bradleat Can you solve the conflict? |
|
Hi guys, When will this PR be merged? What is the current status of it? Best Regards |
| typespec.properties.push(property); | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
This _forEach should replace the above one, otherwise, it will result in duplicated typescript properties.
3 participants
Adding onto #127 we now have type information on the {{responses}} object.