Extended library with Information about "responses"#127
Open
SimplyComple0x78 wants to merge 3 commits intowcandillon:masterfrom
Open
Extended library with Information about "responses"#127SimplyComple0x78 wants to merge 3 commits intowcandillon:masterfrom
SimplyComple0x78 wants to merge 3 commits intowcandillon:masterfrom
Conversation
Author
|
Hey, do you want the change or don't you? I ain't get feedback... is anybody out there? @wcandillon ? |
|
This would be a good change to add, I need this same functionality @wcandillon |
bradleat
approved these changes
Jan 14, 2017
bradleat
left a comment
bradleat
left a comment
There was a problem hiding this comment.
I need the same thing. I'll be adding this into my fork
|
I added #163 which also adds in type information to the response object. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using this library to implement an awesome JS-library that should validate all requests and responses against the given JSON-schema from the swagger-File. While I could do this for requests (since the parameters are there) I can't do it for responses, because the different responses get lost during the lib-internal transformation.
Thus, I added the responses just as they have been defined in the swagge-file to each "method" to enable encouraged developers to add some response-based features in their generated JS-library (especially using "getCustomCode").