Skip to content

fix: kebab-case CLI flags broke in peowly migration#125

Merged
voxpelli merged 3 commits intomainfrom
copilot/investigate-regressions
Feb 23, 2026
Merged

fix: kebab-case CLI flags broke in peowly migration#125
voxpelli merged 3 commits intomainfrom
copilot/investigate-regressions

Conversation

Copy link
Contributor

Copilot AI commented Feb 23, 2026

  • Identify root cause: peowly doesn't auto-convert camelCase flag keys to kebab-case (unlike meow), so engineCheck--engineCheck only, not --engine-check
  • Rename all 7 multi-word flag keys to kebab-case in cli.js
  • Update cli.flags destructuring to kebab-case rename syntax (also serves as a TypeScript compile-time check)
  • Add CLI flag names test suite in test/integration.js with 7 regression tests covering every previously broken flag
  • Add negative test (rejects an unknown flag) to prove assertFlagRecognised would catch a regression — verifies that --engineCheck (camelCase) is correctly rejected as unknown
Original prompt

This section details on the original issue you should resolve

<issue_title>Investigate regressions</issue_title>
<issue_description>See eg. mochajs/mocha#5738 and bcomnes/domstack#214</issue_description>

<agent_instructions>research widely to find the root cause of this regression and make sure to patch it and any other similar regression</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…ion tests

Co-authored-by: voxpelli <34457+voxpelli@users.noreply.github.com>
Copilot AI changed the title [WIP] Investigate and patch regressions in codebase Fix kebab-case CLI flags broken by meow→peowly migration Feb 23, 2026
Copilot AI requested a review from voxpelli February 23, 2026 10:36
@voxpelli voxpelli changed the title Fix kebab-case CLI flags broken by meow→peowly migration fix: kebab-case CLI flags broke in peowly migration Feb 23, 2026
@voxpelli voxpelli marked this pull request as ready for review February 23, 2026 11:34
…own flags

Co-authored-by: voxpelli <34457+voxpelli@users.noreply.github.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a critical regression introduced during the migration from meow to peowly. Unlike meow, peowly does not automatically convert camelCase flag object keys to kebab-case CLI flag names, causing all multi-word CLI flags to break for users.

Changes:

  • Renamed 7 multi-word flag keys from camelCase to kebab-case in cli.js flag definitions
  • Updated flag destructuring to use kebab-case rename syntax (provides TypeScript compile-time safety)
  • Added comprehensive test suite with 7 regression tests and 1 negative test to prevent future regressions

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
cli.js Renamed 7 flag keys to kebab-case ('engine-check', 'peer-check', 'version-check', 'ignore-dev', 'workspace-ignore', 'engine-ignore', 'engine-no-dev') and updated destructuring syntax
test/integration.js Added assertFlagRecognised helper and 8 tests (7 positive + 1 negative) to verify all multi-word flags work correctly

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@voxpelli voxpelli merged commit 09f511a into main Feb 23, 2026
21 of 22 checks passed
@voxpelli voxpelli deleted the copilot/investigate-regressions branch February 23, 2026 11:51
@vp-helper vp-helper bot mentioned this pull request Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate regressions

3 participants