fix: kebab-case CLI flags broke in peowly migration (#125)

* Initial plan

* Fix kebab-case CLI flags broken by meow→peowly migration; add regression tests

Co-authored-by: voxpelli <34457+voxpelli@users.noreply.github.com>

* test: add negative test to validate assertFlagRecognised catches unknown flags

Co-authored-by: voxpelli <34457+voxpelli@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: voxpelli <34457+voxpelli@users.noreply.github.com>

Author: Copilot

cli.js

@@ -47,21 +47,21 @@ const baseFlags = /** @satisfies {Record<string, import('peowly').AnyFlag>} */ (
 });
 
 const checkFlags = /** @satisfies {Record<string, import('peowly').AnyFlag & { listGroup: 'Checks' }>} */ ({
-  engineCheck: {
+  'engine-check': {
     'short': 'e',
     type: 'boolean',
     'default': false,
     description: 'Override default checks and explicitly request an engine range check',
     listGroup: 'Checks',
   },
-  peerCheck: {
+  'peer-check': {
     'short': 'p',
     type: 'boolean',
     'default': false,
     description: 'Override default checks and explicitly request a peer dependency range check',
     listGroup: 'Checks',
   },
-  versionCheck: {
+  'version-check': {
     'short': 'c',
     type: 'boolean',
     'default': false,
@@ -78,7 +78,7 @@ const checkOptionFlags = /** @satisfies {Record<string, import('peowly').AnyFlag
     description: 'Excludes the named dependency from non-version checks (Supports globs)',
     listGroup: 'Check options',
   },
-  ignoreDev: {
+  'ignore-dev': {
     'short': 'd',
     type: 'boolean',
     'default': false,
@@ -129,7 +129,7 @@ const workspaceFlags = /** @satisfies {Record<string, import('peowly').AnyFlag &
     description: 'Excludes all workspace packages not matching these names / paths',
     listGroup: 'Workspace options',
   },
-  workspaceIgnore: {
+  'workspace-ignore': {
     type: 'string',
     multiple: true,
     description: 'Excludes the specified paths from workspace lookup (Supports globs)',
@@ -138,13 +138,13 @@ const workspaceFlags = /** @satisfies {Record<string, import('peowly').AnyFlag &
 });
 
 const deprecatedFlags = /** @satisfies {Record<string, import('peowly').AnyFlag & { listGroup: 'Deprecated options' }>} */ ({
-  engineIgnore: {
+  'engine-ignore': {
     type: 'string',
     multiple: true,
     description: 'Deprecated: use --ignore instead',
     listGroup: 'Deprecated options',
   },
-  engineNoDev: {
+  'engine-no-dev': {
     type: 'boolean',
     'default': false,
     description: 'Deprecated: use --ignore-dev instead',
@@ -178,21 +178,21 @@ if (cli.input.length > 1) {
 
 const {
   debug,
-  engineCheck,
-  engineIgnore, // deprecated
-  engineNoDev, // deprecated
+  'engine-check': engineCheck,
+  'engine-ignore': engineIgnore, // deprecated
+  'engine-no-dev': engineNoDev, // deprecated
   fix,
-  peerCheck,
+  'peer-check': peerCheck,
   strict,
   verbose,
-  versionCheck,
+  'version-check': versionCheck,
   workspace,
-  workspaceIgnore,
+  'workspace-ignore': workspaceIgnore,
 } = cli.flags;
 
 let {
   ignore,
-  ignoreDev,
+  'ignore-dev': ignoreDev,
 } = cli.flags;
 
 const includeWorkspaceRoot = !cli.flags['no-include-workspace-root'];

test/integration.js

@@ -16,6 +16,19 @@ const __dirname = dirname(fileURLToPath(import.meta.url));
 const rootDir = join(__dirname, '..');
 const cliPath = join(rootDir, 'cli-wrapper.cjs');
 
+/**
+ * Asserts that a CLI flag is recognised (not rejected as "Unknown option").
+ *
+ * @param {string} flag
+ */
+async function assertFlagRecognised (flag) {
+  const result = await run(`node "${cliPath}" ${flag} examples/basic`, rootDir);
+  assert.ok(
+    !result.output.includes('Unknown option'),
+    `Flag ${flag} should be recognised by the CLI, got:\n${result.output}`
+  );
+}
+
 describe('Basic Example', () => {
   it('output matches README expected output', async () => {
     const expectedOutput = await extractExpectedOutput(join(rootDir, 'examples/basic/README.md'));
@@ -118,3 +131,29 @@ describe('Monorepo Example', () => {
     );
   });
 });
+
+describe('CLI flag names', () => {
+  // Regression tests: these flags broke when migrating from meow to peowly because
+  // peowly uses flag key names as-is (no camelCase→kebab-case conversion like meow did).
+  // Each test ensures the flag is recognised by the CLI (not rejected as "Unknown option").
+
+  it('rejects an unknown flag (validates assertFlagRecognised itself)', async () => {
+    // A camelCase flag like --engineCheck is unknown to peowly — this negative test
+    // confirms that assertFlagRecognised would catch a regression if a kebab-case key
+    // were accidentally reverted to camelCase.
+    const result = await run(`node "${cliPath}" --engineCheck examples/basic`, rootDir);
+    assert.ok(
+      result.output.includes('Unknown option'),
+      `Expected --engineCheck to be rejected as unknown, got:\n${result.output}`
+    );
+    assert.notEqual(result.code, 0, `Expected non-zero exit code for unknown flag, got ${result.code}`);
+  });
+
+  it('accepts --engine-check', async () => { await assertFlagRecognised('--engine-check'); });
+  it('accepts --peer-check', async () => { await assertFlagRecognised('--peer-check'); });
+  it('accepts --version-check', async () => { await assertFlagRecognised('--version-check'); });
+  it('accepts --ignore-dev', async () => { await assertFlagRecognised('--ignore-dev'); });
+  it('accepts --workspace-ignore', async () => { await assertFlagRecognised('--workspace-ignore=foo'); });
+  it('accepts --engine-ignore (deprecated)', async () => { await assertFlagRecognised('--engine-ignore=foo'); });
+  it('accepts --engine-no-dev (deprecated)', async () => { await assertFlagRecognised('--engine-no-dev'); });
+});