Skip to content

fix: remove unnecessary quotes from vitest-dev override in upgrade script #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengmk2 merged 3 commits into from
Apr 13, 2026
Merged

fix: remove unnecessary quotes from vitest-dev override in upgrade script #1368

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
447d19d
fix: remove unnecessary quotes from vitest-dev override in upgrade sc…
fengmk2 Apr 13, 2026
5f03f87
fix: simplify vitest-dev regex to not handle quotes
fengmk2 Apr 13, 2026
7a679d7
Merge branch 'main' into fix-1367-pr
fengmk2 Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/scripts/upgrade-deps.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,9 @@ async function updatePnpmWorkspace(versions) {
let content = fs.readFileSync(filePath, 'utf8');

// Update vitest-dev override (handle pre-release versions like -beta.1, -rc.0)
// Handle both quoted ('npm:vitest@^...') and unquoted (npm:vitest@^...) forms
content = content.replace(
/vitest-dev: '?npm:vitest@\^[\d.]+(-[\w.]+)?'?/,
`vitest-dev: 'npm:vitest@^${versions.vitest}'`,
/vitest-dev: npm:vitest@\^[\d.]+(-[\w.]+)?/,
`vitest-dev: npm:vitest@^${versions.vitest}`,
);

// Update tsdown in catalog (handle pre-release versions)
Expand Down
Loading