Skip to content

fix: remove unnecessary quotes from vitest-dev override in upgrade script#1368

Merged
fengmk2 merged 3 commits intomainfrom
fix-1367-pr
Apr 13, 2026
Merged

fix: remove unnecessary quotes from vitest-dev override in upgrade script#1368
fengmk2 merged 3 commits intomainfrom
fix-1367-pr

Conversation

@fengmk2
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 commented Apr 13, 2026

Summary

  • The upgrade script was wrapping the vitest-dev override value in single quotes ('npm:vitest@^x.y.z'), but pnpm-workspace.yaml stores it unquoted (npm:vitest@^x.y.z)
  • This caused a spurious formatting change on every automated upgrade run

Closes #1367

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 13, 2026

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit 7a679d7
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/69dc8d0883f19d0008c2f0f6

…ript

The upgrade script was wrapping the vitest-dev override value in single
quotes, but pnpm-workspace.yaml stores it unquoted. This caused a
spurious formatting change on every upgrade run.

Closes #1367
Copy link
Copy Markdown
Member Author

fengmk2 commented Apr 13, 2026


How to use the Graphite Merge Queue

Add the label auto-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 requested a review from cpojer April 13, 2026 01:44
Comment thread .github/scripts/upgrade-deps.mjs Outdated
@fengmk2
Copy link
Copy Markdown
Member Author

fengmk2 commented Apr 13, 2026

ci works #1371

@fengmk2 fengmk2 merged commit fbd56e1 into main Apr 13, 2026
38 checks passed
@fengmk2 fengmk2 deleted the fix-1367-pr branch April 13, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants