Skip to content

Fix Bearer token extraction on headers with leading whitespace #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavanputhra merged 1 commit into from
Mar 9, 2026
Merged

Fix Bearer token extraction on headers with leading whitespace #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/api/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,9 @@ function getHeader(req: IncomingMessage, name: string): string | undefined {
*/
export function getTokenFromRequest(req: IncomingMessage, headerName: string): string | undefined {
const authHeader = getHeader(req, 'authorization');
if (authHeader?.trim().toLowerCase().startsWith('bearer ')) {
return authHeader.slice(7).trim() || undefined;
const trimmedAuthHeader = authHeader?.trim();
if (trimmedAuthHeader?.toLowerCase().startsWith('bearer ')) {
return trimmedAuthHeader.slice(7).trim() || undefined;
}
const value = getHeader(req, headerName);
return value?.trim() || undefined;
Expand Down Expand Up @@ -152,8 +153,9 @@ export function createAuthMiddleware(config?: Partial<AuthConfig>) {

// Get API key: support Authorization: Bearer <token> (MockMCP-style) and configured header
const authHeader = ctx.get('authorization');
const apiKey = authHeader?.trim().toLowerCase().startsWith('bearer ')
? authHeader.slice(7).trim()
const trimmedAuthHeader = authHeader?.trim();
const apiKey = trimmedAuthHeader?.toLowerCase().startsWith('bearer ')
? trimmedAuthHeader.slice(7).trim()
: (ctx.get(authConfig.headerName) || '').trim();

if (!apiKey) {
Expand Down