Fix Bearer token extraction on headers with leading whitespace#37
Merged
pavanputhra merged 1 commit intomainfrom Mar 9, 2026
Merged
Fix Bearer token extraction on headers with leading whitespace#37pavanputhra merged 1 commit intomainfrom
pavanputhra merged 1 commit intomainfrom
Conversation
Trim the Authorization header before slicing to extract the token, so headers like " Bearer token" are parsed correctly instead of producing a corrupted token value. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
authHeader.slice(7)was applied to the original untrimmed string while thestartsWith('bearer ')check used.trim(), causing corrupted token extraction if theAuthorizationheader had leading whitespacegetTokenFromRequest(HTTP) and the Koa middlewareTest plan
Authorization: Bearer <token>(normal) still worksAuthorization: Bearer <token>(leading whitespace) now extracts the correct token🤖 Generated with Claude Code