Skip to content

Support global.localClusterName properly #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
darkdoc merged 2 commits into from
Feb 12, 2026
Merged

Support global.localClusterName properly #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3ab053
Fix default image in values.schema.json
mbaldessari Feb 12, 2026
73801f3
add global.localClusterName
mbaldessari Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ Default always defined top-level variables for helm charts
value: {{ $.Values.global.pattern }}
- name: global.clusterDomain
value: {{ $.Values.global.clusterDomain }}
- name: global.localClusterName
value: {{ $.Values.global.localClusterName }}
- name: global.clusterVersion
value: "{{ $.Values.global.clusterVersion }}"
- name: global.clusterPlatform
Expand Down Expand Up @@ -54,6 +56,9 @@ Default always defined valueFiles to be included in Applications
{{- if $.Values.global.clusterVersion }}
- "/values-{{ $.Values.global.clusterVersion }}-{{ $.Values.clusterGroup.name }}.yaml"
{{- end }}
{{- if $.Values.global.localClusterName }}
- "/values-{{ $.Values.global.localClusterName }}.yaml"
{{- end }}
{{- if $.Values.global.extraValueFiles }}
{{- range $.Values.global.extraValueFiles }}
- {{ . | quote }}
Expand Down Expand Up @@ -103,6 +108,9 @@ Default always defined valueFiles to be included in Applications but with a pref
{{- if $.Values.global.clusterVersion }}
- "$patternref/values-{{ $.Values.global.clusterVersion }}-{{ $.Values.clusterGroup.name }}.yaml"
{{- end }}
{{- if $.Values.global.localClusterName }}
- "$patternref/values-{{ $.Values.global.localClusterName }}.yaml"
{{- end }}
{{- if $.Values.global.extraValueFiles }}
{{- range $.Values.global.extraValueFiles }}
- "$patternref/{{ . }}"
Expand Down
4 changes: 2 additions & 2 deletions tests/application_multi_source_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ tests:
value: acm
lengthEqual:
path: spec.sources[1].helm.parameters
count: 16
count: 17
- documentSelector:
path: metadata.name
value: vault
Expand Down Expand Up @@ -96,4 +96,4 @@ tests:
value: acm
lengthEqual:
path: spec.sources[1].helm.parameters
count: 18
count: 19
4 changes: 2 additions & 2 deletions values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,7 +770,7 @@
},
"image": {
"type": "string",
"default": "registry.redhat.io/ansible-automation-platform-22/ee-supported-rhel8:latest"
"default": "quay.io/validatedpatterns/imperative-container:v1"
},
"namespace": {
"type": "string",
Expand Down Expand Up @@ -868,7 +868,7 @@
},
"image": {
"type": "string",
"default": "registry.redhat.io/ansible-automation-platform-22/ee-supported-rhel8:latest"
"default": "quay.io/validatedpatterns/imperative-container:v1"
},
"tags": {
"type": "string"
Expand Down