Support global.localClusterName properly#90
Merged
darkdoc merged 2 commits intovalidatedpatterns:mainfrom Feb 12, 2026
Merged
Conversation
Contributor
mbaldessari
commented
Feb 12, 2026
- Fix default image in values.schema.json
- add global.localClusterName
This is currently already set by the pattern operator in the clusterwide argo app and by the acm chart in the spoke cluster wide argo app, what is missing is bringing it to the namespaced argo app. Tested on mcg and now all namespaced argo applications correctly have this variable.
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.