Skip to content

docs: use getRouteHierarchy for breadcrumbs Flow router trail#11918

Merged
web-padawan merged 1 commit into
mainfrom
docs/breadcrumbs-flow-route-hierarchy
Jun 11, 2026
Merged

docs: use getRouteHierarchy for breadcrumbs Flow router trail#11918
web-padawan merged 1 commit into
mainfrom
docs/breadcrumbs-flow-route-hierarchy

Conversation

@web-padawan

@web-padawan web-padawan commented Jun 10, 2026

Copy link
Copy Markdown
Member

Depends on #11923

Aligns the breadcrumbs Flow spec, API, and tasks with Flow core PR #24550, which ships the route-hierarchy and instance-free-title APIs the router mode needs.

  • Trail builder — uses the public RouteConfiguration#getRouteHierarchy(target, params) (returns List<RouteParentReference>, root→current, cycle-guarded) instead of the earlier proposed RouteHierarchy.resolveAncestors walker.
  • Instance-free titles — ancestor labels resolve from @PageTitle / PageTitleGenerator without instantiating views; the current view's live HasDynamicTitle is still preferred for the last item. Ancestors resolve with the RouteParameters narrowed to their own template.
  • @RouteParent — now documented as shipping in PR #24550 (static value() + dynamic resolver()); removed the speculative annotation/algorithm code blocks in favour of a PR reference.
  • Reuse section — the "route-hierarchy walker — Proposed" and separate @RouteParent dependency subsections collapse into one concise "Flow core: route hierarchy and titles (PR #24550)" dependency note.
  • Tasks — Task 7 (router wiring) and the dependency header now reference PR #24550; the version-bump note updated accordingly.

Discussion entries added/updated for the API change; spec bodies kept current-state-only and defer API detail to the Flow PR.


🤖 Generated with Claude Code

@web-padawan web-padawan requested a review from vursen June 10, 2026 12:38
@web-padawan web-padawan force-pushed the docs/breadcrumbs-flow-route-hierarchy branch from 047f97f to 3d648f2 Compare June 10, 2026 13:09
@web-padawan web-padawan requested a review from sissbruecker June 10, 2026 13:47
@web-padawan web-padawan force-pushed the docs/breadcrumbs-flow-spec-theme-variants-i18n branch from aea2746 to d82f16e Compare June 11, 2026 07:15
Base automatically changed from docs/breadcrumbs-flow-spec-theme-variants-i18n to main June 11, 2026 07:18
@web-padawan web-padawan force-pushed the docs/breadcrumbs-flow-route-hierarchy branch from 0bfc38b to 385eb3f Compare June 11, 2026 07:23
Comment thread packages/breadcrumbs/spec/flow-tasks.md Outdated
Comment thread packages/breadcrumbs/spec/flow-api.md
@web-padawan web-padawan force-pushed the docs/breadcrumbs-flow-route-hierarchy branch 2 times, most recently from bb85465 to 1f064e3 Compare June 11, 2026 08:33
@web-padawan web-padawan requested a review from sissbruecker June 11, 2026 08:36
@web-padawan web-padawan force-pushed the docs/breadcrumbs-flow-route-hierarchy branch from 4e0b941 to 403bca2 Compare June 11, 2026 10:11
Align the breadcrumbs Flow spec, API and tasks with Flow core PR #24550:
build the router-mode trail on the public RouteConfiguration#getRouteHierarchy
(returning RouteParentReference) and instance-free title resolution, replacing
the earlier proposed RouteHierarchy walker. Refer to the Flow PR for API
details rather than restating them.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@web-padawan web-padawan force-pushed the docs/breadcrumbs-flow-route-hierarchy branch from 403bca2 to dc2d12e Compare June 11, 2026 11:17
@sonarqubecloud

Copy link
Copy Markdown

@web-padawan web-padawan removed the request for review from vursen June 11, 2026 12:03
@web-padawan web-padawan merged commit 40eb9c0 into main Jun 11, 2026
10 checks passed
@web-padawan web-padawan deleted the docs/breadcrumbs-flow-route-hierarchy branch June 11, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants