docs: use UI.routerStateSignal for breadcrumbs initial trail build#11921
Merged
Conversation
web-padawan
force-pushed
the
docs/breadcrumbs-flow-route-hierarchy
branch
from
4e0b941 to
403bca2
Compare
web-padawan
force-pushed
the
docs/cleanup-breadcrumbs-flow-spec
branch
from
b026e93 to
7a1320b
Compare
web-padawan
changed the base branch from
docs/breadcrumbs-flow-route-hierarchy
to
main
web-padawan
force-pushed
the
docs/cleanup-breadcrumbs-flow-spec
branch
2 times, most recently
from
83a8dcf to
38f7d20
Compare
Flow core exposes the current navigation state as a read-only Signal<RouterState> on UI, so the initial trail build reads it with Signal#peek() and the proposed Signal<NavigationState> section shrinks to a short used-as-is dependency entry. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
web-padawan
force-pushed
the
docs/cleanup-breadcrumbs-flow-spec
branch
from
38f7d20 to
ebbb5a0
Compare
|
vursen
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the breadcrumbs Flow spec and tasks with Flow core PR #24234, which ships
UI.routerStateSignal()— a read-onlySignal<RouterState>holding the currentLocation,RouteParameters, active chain, and navigation target class, updated atomically alongsideAfterNavigationEventdispatch.onAttachreads the current navigation state withui.routerStateSignal().peek()instead ofUIInternals, and the secondrebuildFromRouteroverload takes aRouterState. TheAfterNavigationListenerkeeps covering subsequent navigations.Signal<NavigationState>— Proposed" Reuse section is replaced by a short "UI.routerStateSignal()— Used as-is" entry that keeps only what the breadcrumb consumes.Discussion entry added for the initial-read mechanism; spec bodies kept current-state-only.
🤖 Generated with Claude Code