Skip to content

Feat/bionic fg integration#1443

Draft
xXJSONDeruloXx wants to merge 19 commits into
utkarshdalal:masterfrom
xXJSONDeruloXx:feat/bionic-fg-integration
Draft

Feat/bionic fg integration#1443
xXJSONDeruloXx wants to merge 19 commits into
utkarshdalal:masterfrom
xXJSONDeruloXx:feat/bionic-fg-integration

Conversation

@xXJSONDeruloXx
Copy link
Copy Markdown
Contributor

@xXJSONDeruloXx xXJSONDeruloXx commented May 15, 2026

Description

Recording

Screen.Recording.2026-05-15.at.5.08.05.PM-under-10mb.mp4

Type of Change

  • Bug fix
  • Performance / stability improvement
  • Compatibility improvements
  • Other (requires prior approval)

Checklist

  • If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
  • This change aligns with the current project scope (core functionality, stability, or performance). If not, it has been explicitly approved beforehand.
  • I have attached a recording of the change.
  • I have read and agree to the contribution guidelines in CONTRIBUTING.md.

Summary by cubic

Adds Bionic‑FG Vulkan frame generation as an alternative to LSFG‑VK, installing an implicit Vulkan layer that is only enabled on Bionic containers. Now supports in‑session Quick Menu controls with hot‑reload and paced present for smoother source timing.

  • New Features

    • Bundles libbionic-fg-layer.so and an implicit layer manifest; installs under ~/.local with runtime versioning and safe permissions, and removes the manifest when disabled to avoid stale loads.
    • Adds BionicFgManager to install/refresh the layer, write ~/.config/bionic-fg/conf.toml, set VK_LAYER_PATH, and manage BIONIC_FG_* env vars (including BIONIC_FG_PACE_PRESENT and BIONIC_FG_PACE_INTERVAL_MS).
    • Graphics tab and a new Quick Menu tab for Bionic‑FG with Off/2x/3x/4x, flow scale (0.25–1.0), and model (0/1); changes apply live without relaunch.
    • Performance HUD FPS limiter now auto‑disables while any frame generation is active; HUD shows source FPS (not multiplied) and the limiter override message is now generic to frame generation.
  • Migration

    • No action needed; tweak settings in the Graphics tab or Quick Menu and they apply immediately.
    • Supported on Bionic containers; known to work on Adreno 6xx+.

Written for commit 9a004a6. Summary will update on new commits. Review in cubic

xXJSONDeruloXx and others added 12 commits May 13, 2026 15:44
Adds Bionic-FG Vulkan layer integration:
- Prebuilt libbionic-fg-layer.so asset (~10MB)
- VkLayer_BIONIC_framegen.json manifest
- BionicFgManager.kt for layer install + env var management
- ContainerData fields: bionicFgEnabled, multiplier, flowScale, model
- Graphics tab UI: toggle + multiplier slider (2-4) + flow scale (0.25-1.0) + model selector (0/1)
- Launcher integration: sets BIONIC_FG_ENABLE, MULTIPLIER, FLOW_SCALE, MODEL env vars
- String resources for all UI labels

Works alongside existing LSFG-VK — both can be toggled independently.
No hot-reload; settings apply on next container launch.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 15, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 69dd2bb4-cffa-467c-8427-2d5862719aff

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant