Skip to content

chore: update lsfg-vk Android layer to v1.0.2#1437

Merged
utkarshdalal merged 1 commit into
utkarshdalal:masterfrom
xXJSONDeruloXx:chore/update-lsfg-vk-layer-v1.0.2
May 17, 2026
Merged

chore: update lsfg-vk Android layer to v1.0.2#1437
utkarshdalal merged 1 commit into
utkarshdalal:masterfrom
xXJSONDeruloXx:chore/update-lsfg-vk-layer-v1.0.2

Conversation

@xXJSONDeruloXx
Copy link
Copy Markdown
Contributor

@xXJSONDeruloXx xXJSONDeruloXx commented May 13, 2026

Description

brings these changes over to our org fork
FrankBarretta/lsfg-vk-android@release...overlay-support

branch name is misleading, but upstream is using that build in latest android lsfg apk with Mali improvements and debugging coverage

Recording

Type of Change

  • Bug fix
  • Performance / stability improvement
  • Compatibility improvements
  • Other (requires prior approval)

Checklist

  • If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
  • This change aligns with the current project scope (core functionality, stability, or performance). If not, it has been explicitly approved beforehand.
  • I have attached a recording of the change.
  • I have read and agree to the contribution guidelines in CONTRIBUTING.md.

Summary by cubic

Update the lsfg-vk Android layer to v1.0.2 to pick up the latest Vulkan layer binary. Replaces the bundled liblsfg-vk-layer.so, updates the lsfg-vk-android submodule, and bumps RUNTIME_VERSION so the new binary is loaded.

Written for commit 50a5373. Summary will update on new commits.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

📝 Walkthrough

Walkthrough

The PR updates the LSFG Vulkan Android runtime from v1.0.1 to v1.0.2 by pinning the submodule to a new commit hash and bumping the corresponding version constant in LsfgVkManager.kt. This ensures the app recognizes and uses the updated runtime assets.

Changes

LSFG Runtime Version Bump

Layer / File(s) Summary
LSFG runtime version bump to v1.0.2
app/src/main/cpp/lsfg-vk-android, app/src/main/java/app/gamenative/utils/LsfgVkManager.kt
Submodule reference pinned to new commit, and RUNTIME_VERSION constant updated from v1.0.1-android-arm64-v8a to v1.0.2-android-arm64-v8a for runtime install/version cache comparisons.

Possibly related PRs

  • utkarshdalal/GameNative#1351: Prior LSFG runtime version update with the same integration pattern of submodule and version constant synchronization.

Suggested reviewers

  • utkarshdalal

Poem

🐰 A nibble of v1.0.2 arrives today,
Submodules sync in a hoppity way,
Runtime constants dance hand in hand,
The Android runtime's updated grand! 🎮


🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete and largely unfilled. Required template sections lack substantive content or are empty. Complete the Description section with clear details about what changed and why. Specify the type of change with a checkbox. Confirm checklist items, especially discussion in #code-changes and recording attachment if applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating the lsfg-vk Android layer to v1.0.2, which aligns with the submodule update and version bump changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@utkarshdalal
Copy link
Copy Markdown
Owner

Does this still need review/merging or should we hold off in favour of #1443?

@xXJSONDeruloXx
Copy link
Copy Markdown
Contributor Author

@utkarshdalal i don't think bionic fg replaces lsfg, should update regardless

@utkarshdalal utkarshdalal merged commit f51dfeb into utkarshdalal:master May 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants