More precise use-defs#48
Merged
Merged
Conversation
…e use-defs more precise
…use-defs are computed
Member
|
Looks great. Only surgical changes to get the desired functionality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the signature of
define(anddefineInScope), so Typepal users can now pass the name of a definition as a tree (instead of a string). If so, then all uses of that definition are directed to the location of that tree (instead of the whole definition) by theuseDefrelation. This enables more precise Go To Definition support. The changes of this PR are fully backward-compatible (i.e., the name of a definition can still be defined as a string instead of a tree).Technically, this PR adds a new
define2idproperty toTModelfor necessary bookkeeping.Successful integration test: https://github.com/usethesource/rascal-core-big-tests/actions/runs/27205996870