More precise use-defs#2801
Open
sungshik wants to merge 4 commits into
Open
Conversation
…r (needed, e.g., in the rename code)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2801 +/- ##
=======================================
- Coverage 46% 46% -1%
- Complexity 6723 6724 +1
=======================================
Files 839 839
Lines 66766 66766
Branches 9983 9983
=======================================
- Hits 30781 30777 -4
- Misses 33598 33601 +3
- Partials 2387 2388 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR updates
defineanddefineInScopecalls based on usethesource/typepal#48 in the Rascal typechecker to compute more precise use-def relations. Due to earlier preparatory work in #2770, essentially the only changes of this PR are rewrites of the form:define("<tree>", ...)->define(tree, ...).The integration test succeeds (in combination with companion PR usethesource/rascal-language-servers#1113).