Skip to content

test(e2e): remove legacy scaffolding after Ginkgo migration#532

Open
IrvingMg wants to merge 1 commit intourunc-dev:mainfrom
IrvingMg:cleanup/e2e-migrate-to-ginkgo
Open

test(e2e): remove legacy scaffolding after Ginkgo migration#532
IrvingMg wants to merge 1 commit intourunc-dev:mainfrom
IrvingMg:cleanup/e2e-migrate-to-ginkgo

Conversation

@IrvingMg
Copy link
Contributor

Description

This PR cleans up the remaining unused code from the migration.

Related issues

How was this tested?

  • make e2etest

LLM usage

Claude Code (Opus 4.6)

Checklist

  • I have read the contribution guide.
  • The linter passes locally (make lint).
  • The e2e tests of at least one tool pass locally (make test_ctr, make test_nerdctl, make test_docker, make test_crictl).
  • If LLMs were used: I have read the llm policy.

@netlify
Copy link

netlify bot commented Mar 11, 2026

Deploy Preview for urunc canceled.

Name Link
🔨 Latest commit 3b7b814
🔍 Latest deploy log https://app.netlify.com/projects/urunc/deploys/69b471f79f3b2f00083a3c04

Copy link
Contributor

@cmainas cmainas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @IrvingMg thank you for the cleanup. One comment that we can discuss over.

I think it would be better to place all the new functions of tests/e2e/common.go (e.g. getTestImages) in a separate file and keep the common go file as a file that contains common functions for the various tools. Maybe, a better file to place them would be tests/e2e/utils.go or rename tests/e2e/setup_test.go.

Signed-off-by: Irving Mondragón <mirvingr@gmail.com>
@IrvingMg IrvingMg force-pushed the cleanup/e2e-migrate-to-ginkgo branch from 193200c to 3b7b814 Compare March 13, 2026 20:22
@IrvingMg
Copy link
Contributor Author

Hello @IrvingMg thank you for the cleanup. One comment that we can discuss over.

I think it would be better to place all the new functions of tests/e2e/common.go (e.g. getTestImages) in a separate file and keep the common go file as a file that contains common functions for the various tools. Maybe, a better file to place them would be tests/e2e/utils.go or rename tests/e2e/setup_test.go.

Done. Moved the image management functions and constants to utils.go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants