Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
231 changes: 208 additions & 23 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
"devDependencies": {
"@types/node": "^20.11.24",
"@typescript-eslint/eslint-plugin": "^7.1.0",
"@typescript-eslint/parser": "^7.1.0",
"@typescript-eslint/parser": "^8.56.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The @typescript-eslint/parser is updated to v8 while @typescript-eslint/eslint-plugin remains on v7. This major version mismatch will cause the CI linting step to fail.
Severity: CRITICAL

Suggested Fix

Update the @typescript-eslint/eslint-plugin dependency in package.json to match the major version of @typescript-eslint/parser. For instance, change @typescript-eslint/eslint-plugin to ^8.56.1 to align with the parser's new version.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: package.json#L71

Potential issue: The pull request upgrades `@typescript-eslint/parser` to version
`8.56.1` but leaves `@typescript-eslint/eslint-plugin` at `^7.1.0`. The installed
plugin, version `7.18.0`, has a peer dependency requirement for
`@typescript-eslint/parser` in the `^7.0.0` range. The new parser version `8.56.1` does
not satisfy this requirement. This major version mismatch between the parser (v8) and
the plugin (v7) is a strict violation of the package's peer dependency contract. As a
result, running the `bun run lint` command, which is a required step in the CI pipeline,
will throw an error and fail, blocking the CI/CD process.

Did we get this right? 👍 / 👎 to inform future reviews.

"@vitest/coverage-v8": "^4.0.18",
"eslint": "^8.57.0",
"tsx": "^4.7.1",
Expand Down
Loading