chore(deps-dev): bump @typescript-eslint/parser from 7.18.0 to 8.56.1#2
Closed
dependabot[bot] wants to merge 1 commit intomainfrom
Closed
chore(deps-dev): bump @typescript-eslint/parser from 7.18.0 to 8.56.1#2dependabot[bot] wants to merge 1 commit intomainfrom
dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 7.18.0 to 8.56.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.56.1/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-version: 8.56.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
| "@types/node": "^20.11.24", | ||
| "@typescript-eslint/eslint-plugin": "^7.1.0", | ||
| "@typescript-eslint/parser": "^7.1.0", | ||
| "@typescript-eslint/parser": "^8.56.1", |
There was a problem hiding this comment.
Bug: The @typescript-eslint/parser is updated to v8 while @typescript-eslint/eslint-plugin remains on v7. This major version mismatch will cause the CI linting step to fail.
Severity: CRITICAL
Suggested Fix
Update the @typescript-eslint/eslint-plugin dependency in package.json to match the major version of @typescript-eslint/parser. For instance, change @typescript-eslint/eslint-plugin to ^8.56.1 to align with the parser's new version.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L71
Potential issue: The pull request upgrades `@typescript-eslint/parser` to version
`8.56.1` but leaves `@typescript-eslint/eslint-plugin` at `^7.1.0`. The installed
plugin, version `7.18.0`, has a peer dependency requirement for
`@typescript-eslint/parser` in the `^7.0.0` range. The new parser version `8.56.1` does
not satisfy this requirement. This major version mismatch between the parser (v8) and
the plugin (v7) is a strict violation of the package's peer dependency contract. As a
result, running the `bun run lint` command, which is a required step in the CI pipeline,
will throw an error and fail, blocking the CI/CD process.
Did we get this right? 👍 / 👎 to inform future reviews.
Author
|
Superseded by #12. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps @typescript-eslint/parser from 7.18.0 to 8.56.1.
Release notes
Sourced from
@typescript-eslint/parser's releases.... (truncated)
Changelog
Sourced from
@typescript-eslint/parser's changelog.... (truncated)
Commits
96a04a9chore(release): publish 8.56.18b8b68fchore(release): publish 8.56.068a074ffeat: support ESLint v10 (#12057)fedfe86chore(release): publish 8.55.0b931f8cchore: use workspace refs for workspace deps (#12018)1f17a79chore: migrate to pnpm (#11248)d423e57chore(release): publish 8.54.09940e53chore(release): publish 8.53.13021edechore(release): publish 8.53.09ddd571chore(release): publish 8.52.0Maintainer changes
This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for
@typescript-eslint/parsersince your current version.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)