Conversation
added 5 commits
May 3, 2026 15:23
…eckpoint. Added buttons to switch ros2 states in Arm and Drive tab. Reformatted Camera Layout. Added ROS2 Command Sending in Navigation Tab
mdurrani808
reviewed
May 5, 2026
Contributor
mdurrani808
left a comment
mdurrani808
left a comment
There was a problem hiding this comment.
very vague look at this, had chat help
| }; | ||
|
|
||
| const resetStopwatch = () => { | ||
| stopwatchStartRef.current = Date.now(); |
Contributor
There was a problem hiding this comment.
is this correct? why is the current time now when resetting if it isnt running?
Contributor
There was a problem hiding this comment.
Chat said this:
- Components defined inside render (ScienceMonitor.js)
CameraCard and CameraImage are declared inside the component body. React creates new component
identities on every render, causing camera feeds to unmount/remount (drop and reconnect) on any
state change. Lift them outside the component.
| pc.addIceCandidate({ candidate: msg.candidate, sdpMLineIndex: msg.sdpMLineIndex }).catch(() => {}); | ||
| pc.addIceCandidate({ | ||
| candidate: msg.candidate, | ||
| sdpMLineIndex: msg.sdpMLineIndex ?? msg.mlineIndex ?? 0, |
Contributor
There was a problem hiding this comment.
Why default to 0 here? Could be a valid index
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Science GUI Stylistically. Added an Indicator for when location is reached. Added ROS2 command buttons for quick ros2 command access for drive (placeholders for now) and for Arm (switch to joint by joint or cylindrical control). Changed Camera Layout to fit the rover.