Skip to content

Fix dialog content overflow on small viewports #42473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdo wants to merge 1 commit into
base: v6-dev
Choose a base branch
from
+10 −3
Open

Fix dialog content overflow on small viewports #42473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions scss/_dialog.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,11 @@ $dialog-sizes: defaults(
max-height: calc(100% - var(--dialog-margin) * 2);
padding: 0;
margin: auto;
overflow: visible;
// Scroll the whole dialog (header/footer included) when its content
// exceeds the max-height, instead of letting it overflow off-screen.
// Mirrors v5's default modal, where the entire dialog scrolls; the
// .dialog-scrollable variant keeps the header/footer fixed instead.
overflow: auto;
color: var(--dialog-color);
visibility: hidden;
background-color: var(--dialog-bg);
Expand Down Expand Up @@ -121,7 +125,7 @@ $dialog-sizes: defaults(
// the dialog in the top layer during the exit so the ::backdrop and
// the browser's modal centering remain intact).
&[open]:not(.hiding) {
overflow: visible;
overflow: auto;
visibility: visible;
opacity: 1;
@include transition(
Expand Down Expand Up @@ -170,7 +174,7 @@ $dialog-sizes: defaults(
// fall through to the base "exit" state — for instant dialogs, .hiding
// is removed synchronously after close() so this still applies normally.
&[open]:not(.hiding) {
overflow: visible;
overflow: auto;
visibility: visible;
opacity: 1;
transform: none;
Expand All @@ -190,6 +194,9 @@ $dialog-sizes: defaults(
// Scrollable dialog body (header/footer stay fixed)
&.dialog-scrollable[open] {
max-height: calc(100% - var(--dialog-margin) * 2);
// Keep the dialog itself from scrolling so only the body does,
// leaving the header and footer pinned.
overflow: hidden;

.dialog-body {
overflow-y: auto;
Expand Down