Fix dialog content overflow on small viewports#42473
Open
mdo wants to merge 1 commit into
Open
Conversation
Contributor
|
Test: https://deploy-preview-42473--twbs-bootstrap.netlify.app/docs/6.0/components/dialog Tested on Safari 26.5, Edge 148 and Firefox 151 with no issues. The scrollbar does appear on the dialog itself though, with Bootstrap v5 the scrollbar was on the main body which was preferable I think. I haven't looked into if that is possible though. Firefox 151 (macOS) with this fix: Firefox 151 (macOS) with Bootstrap 5 |
3 tasks
|
I checked the test link above. It would be great if it could stay consistent with Bootstrap 5. I’m not sure whether this can be achieved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #42459.
Default
.dialogusedoverflow: visible, so when content was taller than the viewport the body/footer rendered off-screen and unreachable. Switched the default dialog tooverflow: autoso the whole dialog scrolls within itsmax-height(matching v5's default modal), and set.dialog-scrollabletooverflow: hiddenso only its body scrolls with the header/footer pinned.