feat(ai): ChatGPT sign-in UI and shared Connected/picker order (#284) by tuckcode · Pull Request #286 · tuckcode/rhizome-agent

tuckcode · 2026-11-01T04:54:42Z

Closes #284

Summary

Wires oauth_sign_in / oauth_status / oauth_sign_out / oauth_cancel into Settings → Connected and the native chat model picker.

Accounts (ChatGPT first; catalog leaves room for later providers) sit above API keys → Local → Free.
Within a section, Ready sorts above needs-setup; Not installed local CLIs collapse at the bottom so the list does not open on Codex / OpenCode / Antigravity / Kiro when they are missing.
Default chat target is the first ready model (catalog/seed order within a readiness bucket), so a signed-out ChatGPT / keyless OpenAI cannot win over Ollama.
Ricky: reuse SIGN_IN_AGAIN from provider_oauth; no signed-in ChatGPT chrome when the OpenAI base URL ≠ api.openai.com.
Connected Free (Taproot) Manage opens the existing FreeTierSettings row (no duplicated Free controls).
English hardcoded for this pass (C18 / en.json hold). Does not touch App / ChatHome / AiMessage / rhizome_loop.

Critiquito holds from #283 (landed here; Dank’s #283 PR leaves them to us)

Connected list order — Ready → Needs setup/key → Not installed (collapsed). Not-installed local agent tools do not lead the open list.
Remove Claude Code from the Connected local-CLI agent rows only (accounts list unchanged).

Out of scope (Dank #283)

Add-key scroll/focus, Settings model display label, error vs empty states — untouched. #283 strings stay out of en.json.

Review shots

docs/review-shots/chatgpt-signin/ — Graphite + Earth: connected, picker, signed-in.

Test plan

Focused vitest for Connected / picker / oauth / list order / first-ready default / parity
tsc --noEmit
Full husky pre-push (frontend coverage + rust llvm-cov + playwright smoke): passed in 4m 31s on ba374fee
Manual: real ChatGPT sign-in on Connected, and a chat reply from an account model
Manual: sign-out, cancel, and picker sign-in

Added by Claude Code

list_chatgpt_account_models replaces the catalog gpt-4.1-mini row with the account's live models.
Free-tier commands run off the main thread, so a keychain prompt cannot freeze the window (C100).
Two macOS test fixes (C98, C99).
Open: keychain reads can repeat. Key save, delete, and test commands still run on the main thread.

🤖 Generated with Claude Code

codacy-production · 2026-11-01T04:56:15Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 149 complexity · 0 duplication

Metric Results

Complexity 149

Duplication 0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

Wire oauth_sign_in / status / sign_out / cancel into Settings > Connected and the native chat model picker. Accounts (ChatGPT) sit above API keys, Local, and Free; not-installed local CLIs collapse at the bottom; Ready sorts above needs-setup within a section. Default chat target is the first ready model so a signed-out ChatGPT cannot win. Claude Code is dropped from the Connected agent list only (Critiquito #283 hold). Leave room in the accounts catalog for later providers. English is hardcoded for this pass (C18 / en.json hold). Graphite and Earth review shots included. Co-Authored-By: Grok 4.7 <noreply@x.ai>

Alias catalog open_ai to openai, isolate local empty hints, share one oauth hook between Settings picker and Connected, gate account Ready on the official host, and cover the Codacy/void braces and section-label switch. Manage wraps ready API key paste fields; Sign in stays on the accounts row only.

Recapture Connected signed-in (email) and full pickers through Free/ Taproot. Ready API key rows keep a single Manage control.

…token Split Connected focus Manage-expand from the RAF retry loop so oauth refresh does not cancel setTimeout-backed fake timers. Expect catalog targets as openai/* and the attention footer warning token.

Re-capture Graphite/Earth connected, signed-in, and picker frames after the openai alias and Connected Manage/focus work so raw URLs pin to the final SHA.

Email only in signed-in picker label; Ready ChatGPT owns gpt-* rows (ADR-0186, no API-key dupes). Local picker rows are model-only. Connected lists account models when Ready, adds Free Taproot Manage that opens FreeTierSettings, and puts Manage top-right on ready key rows. Chip middot uses padding; cancel clears busy-provider error; drop orphaned connected title.

Flex was collapsing {' · '} visually; whitespace-pre preserves the spaced middot in the DOM without padding-only textContent loss.

Re-capture Graphite/Earth Connected and picker frames at the HOLD2 tip so Free/Taproot shows on Connected; capture waits for the Free section.

The MCP symlink-cycle test now resolves the macOS temp path. The provider-ux smoke test now uses ControlOrMeta+, for Settings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

A macOS keychain prompt froze the window for 61 seconds, because get_free_tier_overview ran as a sync Tauri command. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

The picker offered only the catalog gpt-4.1-mini, and OpenAI refuses it for a ChatGPT account. list_chatgpt_models had no caller. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

The starter check refused an existing wiki vault at Documents/Rhizome Vault. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Portent stays credited in the app credits and THIRD_PARTY_NOTICES. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

tuckcode mentioned this pull request Nov 1, 2026

fix: provider UX — add-key focus, shared model label, matching load states (#283) #285

Merged

2 of 6 tasks

tuckcode force-pushed the g-baby/chatgpt-signin-ui branch from 4fa1683 to f11a79e Compare November 1, 2026 09:59

tuckcode and others added 13 commits November 1, 2026 04:00

chore(docs): refresh ChatGPT sign-in review shots after #285 rebase

b5fa343

chore(docs): HOLD #286 review shots and ready-key Manage

9e3aee9

Recapture Connected signed-in (email) and full pickers through Free/ Taproot. Ready API key rows keep a single Manage control.

test(ai): align HOLD #286 expectations with openai alias and warning …

4764e3c

…token Split Connected focus Manage-expand from the RAF retry loop so oauth refresh does not cancel setTimeout-backed fake timers. Expect catalog targets as openai/* and the attention footer warning token.

chore(docs): regenerate ChatGPT sign-in review shots at HOLD fix tip

b17f362

Re-capture Graphite/Earth connected, signed-in, and picker frames after the openai alias and Connected Manage/focus work so raw URLs pin to the final SHA.

fix(ai): brace Connected Manage onClick for Codacy void-arrow

79b37a2

fix(ai): keep chip middot spaces with whitespace-pre

6f576f6

Flex was collapsing {' · '} visually; whitespace-pre preserves the spaced middot in the DOM without padding-only textContent loss.

chore(docs): HOLD2 ChatGPT sign-in review shots with Free row

edbfaba

Re-capture Graphite/Earth Connected and picker frames at the HOLD2 tip so Free/Taproot shows on Connected; capture waits for the Free section.

test: make two gates pass on macOS (C98, C99)

0c26949

The MCP symlink-cycle test now resolves the macOS temp path. The provider-ux smoke test now uses ControlOrMeta+, for Settings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix: keep free tier keychain reads off the main thread (C100)

73cba27

A macOS keychain prompt froze the window for 61 seconds, because get_free_tier_overview ran as a sync Tauri command. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix: show the signed-in ChatGPT account's models

ba374fe

The picker offered only the catalog gpt-4.1-mini, and OpenAI refuses it for a ChatGPT account. list_chatgpt_models had no caller. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs: record the PR 286 Mac app install

381e98b

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

tuckcode marked this pull request as ready for review November 2, 2026 01:36

tuckcode and others added 3 commits November 1, 2026 19:49

fix: open a wiki vault at the default folder path (C101)

31f9004

The starter check refused an existing wiki vault at Documents/Rhizome Vault. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix: name the starter template plainly on the welcome screen

c2152ee

Portent stays credited in the app credits and THIRD_PARTY_NOTICES. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs: record the c2152ee Mac app install

49f2ce7

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

tuckcode merged commit ec1f12a into main Nov 2, 2026
11 checks passed

tuckcode deleted the g-baby/chatgpt-signin-ui branch November 2, 2026 02:26

Navigation Menu

Repository navigation

feat(ai): ChatGPT sign-in UI and shared Connected/picker order (#284) - #286

feat(ai): ChatGPT sign-in UI and shared Connected/picker order (#284)#286
tuckcode merged 17 commits into
mainfrom
g-baby/chatgpt-signin-ui

tuckcode commented Nov 1, 2026 •

edited

Loading

Uh oh!

codacy-production Bot commented Nov 1, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

tuckcode commented Nov 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Critiquito holds from #283 (landed here; Dank’s #283 PR leaves them to us)

Out of scope (Dank #283)

Review shots

Test plan

Added by Claude Code

Uh oh!

codacy-production Bot commented Nov 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Up to standards ✅

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

tuckcode commented Nov 1, 2026 •

edited

Loading

codacy-production Bot commented Nov 1, 2026 •

edited

Loading