Repository navigation
fix: provider UX — add-key focus, shared model label, matching load states (#283) - #285
Merged
Merged
Conversation
…tates (#283) - Add key from the picker scrolls/focuses the Connected key field and briefly highlights the row (past the AI section start scroll race). - Chip and Settings share the "Provider · model" trigger label; raw target id stays in the tooltip. - Empty vs timeout probes now map to distinct no_models / load_failed states with matching copy via existing i18n keys (en.json untouched; held by #284).
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 47 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
tuckcode
marked this pull request as ready for review
November 1, 2026 06:24
Split the chip label so the provider truncates first and the model stays visible. Replace the 120ms Add key focus delay with rAF retry up to ~1s, and only consume the focus request after focus or the cap.
Skip trigger refocus on Add key/open-settings close; format unmatched ids as Provider · model from providers; prefer model ellipsis after provider shrink on the chip.
Skip Settings open autofocus and AI section jump while Add key owns focus. Format unlisted chat models via catalog/title-case when providers are empty. Prefer shrinking the chip provider span; reset skipCloseAutoFocusRef on open. Add Playwright smoke covering the real browser flows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatChatModelLabel/rhizomeChatModelTriggerLabel; raw model id stays in the tooltip.ai.composer.noModelsFound) vs Couldn't load models + Retry (ai.composer.couldntLoadModels/settings.connected.loadFailed), driven by probeempty→no_modelsand timeout →load_failed.Fixes #283
Notes
Test plan
pnpm lint/pnpm typecheck/ full vitestOut of scope here (Critiquito #283 P1s)