Skip to content

Log URL with correct protocol in Net::HTTP requests #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trusche merged 1 commit into from
Feb 23, 2026
+7 −1
Merged

Log URL with correct protocol in Net::HTTP requests #186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/httplog/adapters/net_http.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ class HTTP
alias orig_connect connect unless method_defined?(:orig_connect)

def request(req, body = nil, &block)
url = "http://#{@address}:#{@port}#{req.path}"
url = "#{protocol}://#{@address}:#{@port}#{req.path}"

bm = Benchmark.realtime do
@response = orig_request(req, body, &block)
Expand Down Expand Up @@ -46,5 +46,11 @@ def connect

orig_connect
end

private

def protocol
use_ssl? ? 'https' : 'http'
end
end
end
Loading