Log URL with correct protocol in Net::HTTP requests#186
Merged
trusche merged 1 commit intotrusche:masterfrom Feb 23, 2026
Merged
Log URL with correct protocol in Net::HTTP requests#186trusche merged 1 commit intotrusche:masterfrom
trusche merged 1 commit intotrusche:masterfrom
Conversation
Previously URLs were always logged with "http://" even if the connection was made over SSL.
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where URLs were always logged with "http://" prefix even when connections were made over SSL. The fix checks the use_ssl? method to determine whether to use "https" or "http" as the protocol prefix.
Changes:
- Added a private
protocolhelper method that returns "https" or "http" based on the SSL connection state - Updated URL construction to use the dynamic protocol instead of hardcoded "http://"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
trusche
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously URLs were always logged with "http://" even if the connection was made over SSL. E.g.
use_ssl?is now checked when deciding what protocol to prefix the URL with.Test are passing and tweak has been manually confirmed with an SSL connection: