Skip to content

fix(webapp): progress native self-hosted deployments instead of dead enqueue path #3261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flowq-C wants to merge 1 commit into from
Closed

fix(webapp): progress native self-hosted deployments instead of dead enqueue path #3261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions apps/webapp/app/v3/services/initializeDeployment.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,12 +249,16 @@ export class InitializeDeploymentService extends BaseService {
new Date(Date.now() + timeoutMs)
);

// For github integration there is no artifactKey, hence we skip it here
// For self-hosted native builds, progressing the deployment is the action that actually
// transitions the deployment out of PENDING and starts the local build path.
// For github integration there is no artifactKey, hence we skip it here.
if (payload.isNativeBuild && payload.artifactKey && !payload.skipEnqueue) {
const result = await deploymentService
.enqueueBuild(environment, deployment, payload.artifactKey, {
skipPromotion: payload.skipPromotion,
configFilePath: payload.configFilePath,
.progressDeployment(environment, deployment.friendlyId, {
contentHash: payload.contentHash,
git: payload.gitMeta,
runtime: payload.runtime,
buildServerMetadata,
})
.orElse((error) => {
logger.error("Failed to enqueue build", {
Expand Down