fix(webapp): progress native self-hosted deployments instead of dead enqueue path#3261
fix(webapp): progress native self-hosted deployments instead of dead enqueue path#3261flowq-C wants to merge 1 commit intotriggerdotdev:mainfrom
Conversation
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe change updates the native-build enqueue pathway in the deployment initialization service. Instead of calling Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @flowq-C, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details. |
|
Thanks for the quick signal. We opened this PR while debugging multiple reproducible self-hosted deployment failures in a real Trigger.dev self-hosted setup. Relevant linked issues:
This PR is meant as a minimal proposed fix, not a drive-by feature change. If external PRs require a vouch first, the practical ask is:
We are happy to adjust the patch, split it further, or add a changeset if needed once there is a path for contribution. |
|
Follow-up from live validation: We continued debugging this against the same self-hosted installation and got the deploy path working end-to-end. This PR still matches one of the real failure modes we saw early in the process:
After repairing the full path, we successfully deployed newer versions and created background workers in the real self-hosted environment. So even though this PR was auto-closed by contribution policy, the underlying failure mode was real in our repro and not just a local misread of deployment state. |
Summary
In self-hosted native deployments, deployments could remain stuck on
PENDINGor laterTIMED_OUTbecause the expected build transition was not happening through the current enqueue path.In our self-hosted reproduction, progressing the deployment was the action that actually moved the deployment forward and allowed the build/runtime flow to continue.
What changed
enqueueBuild(...)toprogressDeployment(...)Why
Real-world failure mode
PENDINGTIMED_OUTNotes
Closes #3256