-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add tower apps cancel command to cancel running runs
#215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
socksy
wants to merge
1
commit into
develop
Choose a base branch
from
feature/cancel-runs-on-cli
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -338,6 +338,24 @@ async def describe_run(name: str, seq: int): | |
| ) | ||
|
|
||
|
|
||
| @app.post("/v1/apps/{name}/runs/{seq}") | ||
| async def cancel_run(name: str, seq: int): | ||
| """Mock endpoint for cancelling a run.""" | ||
| if name not in mock_apps_db: | ||
| raise HTTPException(status_code=404, detail=f"App '{name}' not found") | ||
|
|
||
| for run_id, run_data in mock_runs_db.items(): | ||
| if run_data["app_name"] == name and run_data["number"] == seq: | ||
| run_data["status"] = "cancelled" | ||
| run_data["status_group"] = "successful" | ||
| run_data["cancelled_at"] = now_iso() | ||
| return {"run": run_data} | ||
|
Comment on lines
+347
to
+352
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Restrict cancellation to active runs only. The handler currently marks any matched run as cancelled. This can incorrectly allow cancelling already terminal runs and drifts from the “cancel running runs” behavior. 💡 Proposed fix- for run_id, run_data in mock_runs_db.items():
+ for run_id, run_data in mock_runs_db.items():
if run_data["app_name"] == name and run_data["number"] == seq:
+ if run_data["status"] not in {"running", "pending", "scheduled"}:
+ raise HTTPException(
+ status_code=409,
+ detail=f"Run sequence {seq} for app '{name}' is not cancellable from status '{run_data['status']}'",
+ )
run_data["status"] = "cancelled"
run_data["status_group"] = "successful"
run_data["cancelled_at"] = now_iso()
return {"run": run_data}🤖 Prompt for AI Agents |
||
|
|
||
| raise HTTPException( | ||
| status_code=404, detail=f"Run sequence {seq} not found for app '{name}'" | ||
| ) | ||
|
|
||
|
|
||
| # Placeholder for /secrets endpoints | ||
| @app.get("/v1/secrets") | ||
| async def list_secrets(): | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want the interface to be
cancel {app_name} {seq}orcancel --app-name {name} --seq {seq}?