feat: add tower apps cancel command to cancel running runs#215
Open
feat: add tower apps cancel command to cancel running runs#215
tower apps cancel command to cancel running runs#215Conversation
Expose the existing cancel_run API endpoint through the CLI and MCP server. Adds `tower apps cancel <app_name> <run_number>` as a subcommand under apps (consistent with existing `apps show`, `apps logs`, etc.) and a corresponding `tower_apps_cancel` MCP tool. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/mock-api-server/main.py`:
- Around line 347-352: The cancellation loop in tests/mock-api-server/main.py
currently cancels any matched run; change it to only cancel runs whose run_data
indicates they are active (e.g., check run_data["status_group"] == "running" or
that run_data["status"] is not in terminal states). In the loop that iterates
mock_runs_db items (referencing mock_runs_db, run_data, name, seq, now_iso), add
a guard to skip non-active runs before setting run_data["status"],
run_data["status_group"], and run_data["cancelled_at"], and only return the
modified run when the run was actually running.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (6)
crates/tower-cmd/src/api.rscrates/tower-cmd/src/apps.rscrates/tower-cmd/src/lib.rscrates/tower-cmd/src/mcp.rstests/integration/features/cli_runs.featuretests/mock-api-server/main.py
Comment on lines
+347
to
+352
| for run_id, run_data in mock_runs_db.items(): | ||
| if run_data["app_name"] == name and run_data["number"] == seq: | ||
| run_data["status"] = "cancelled" | ||
| run_data["status_group"] = "successful" | ||
| run_data["cancelled_at"] = now_iso() | ||
| return {"run": run_data} |
There was a problem hiding this comment.
Restrict cancellation to active runs only.
The handler currently marks any matched run as cancelled. This can incorrectly allow cancelling already terminal runs and drifts from the “cancel running runs” behavior.
💡 Proposed fix
- for run_id, run_data in mock_runs_db.items():
+ for run_id, run_data in mock_runs_db.items():
if run_data["app_name"] == name and run_data["number"] == seq:
+ if run_data["status"] not in {"running", "pending", "scheduled"}:
+ raise HTTPException(
+ status_code=409,
+ detail=f"Run sequence {seq} for app '{name}' is not cancellable from status '{run_data['status']}'",
+ )
run_data["status"] = "cancelled"
run_data["status_group"] = "successful"
run_data["cancelled_at"] = now_iso()
return {"run": run_data}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@tests/mock-api-server/main.py` around lines 347 - 352, The cancellation loop
in tests/mock-api-server/main.py currently cancels any matched run; change it to
only cancel runs whose run_data indicates they are active (e.g., check
run_data["status_group"] == "running" or that run_data["status"] is not in
terminal states). In the loop that iterates mock_runs_db items (referencing
mock_runs_db, run_data, name, seq, now_iso), add a guard to skip non-active runs
before setting run_data["status"], run_data["status_group"], and
run_data["cancelled_at"], and only return the modified run when the run was
actually running.
jo-sm
reviewed
Mar 3, 2026
Comment on lines
+79
to
+95
| .subcommand( | ||
| Command::new("cancel") | ||
| .arg( | ||
| Arg::new("app_name") | ||
| .value_parser(value_parser!(String)) | ||
| .index(1) | ||
| .required(true) | ||
| .help("Name of the app"), | ||
| ) | ||
| .arg( | ||
| Arg::new("run_number") | ||
| .value_parser(value_parser!(i64)) | ||
| .index(2) | ||
| .required(true) | ||
| .help("Run number to cancel"), | ||
| ) | ||
| .about("Cancel a running app run"), |
Member
There was a problem hiding this comment.
Do we want the interface to be cancel {app_name} {seq} or cancel --app-name {name} --seq {seq}?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the existing cancel_run API endpoint through the CLI and MCP server. Adds
tower apps cancel <app_name> <run_number>as a subcommand under apps (consistent with existingapps show,apps logs, etc.) and a correspondingtower_apps_cancelMCP tool.Summary by CodeRabbit
cancelcommand to terminate running app runs. Users can now cancel specific application runs by providing the app name and run number, improving control over long-running processes without requiring manual intervention or waiting for natural completion.