Draft: convert the script to a pure POSIX compliant implementation#3
Open
leonheldattoradex wants to merge 4 commits intotoradex:masterfrom
Open
Draft: convert the script to a pure POSIX compliant implementation#3leonheldattoradex wants to merge 4 commits intotoradex:masterfrom
leonheldattoradex wants to merge 4 commits intotoradex:masterfrom
Conversation
Previously, the script assumed the existance of GNU sed, which is not present on FreeBSD and Darwin systems, silently failing when executed. For more information on sed's POSIX compliance, check the STANDARDS section on SED(1) shipped with FreeBSD as of 14-2. Signed-off-by: Leonardo Held <leonardo.held@toradex.com>
Related-to: TCB-297 Signed-off-by: Leonardo Held <leonardo.held@toradex.com>
tcb is currently available only for amd64. This change enables users running other architectures to at least utilize emulation to run tcb. Signed-off-by: Leonardo Held <leonardo.held@toradex.com>
Signed-off-by: Leonardo Held <leonardo.held@toradex.com>
|
I think making |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've also taken the chance to run
shfmtandshellcheckon the script.This is not well tested and contains changes made in #2 so I'm leaving as draft for us to perhaps pick it up in the future, if there's need.