Skip to content

fix: correct snapshot handler argument passing #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aazamil wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct snapshot handler argument passing #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ludus_mcp/server/tools/batch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,8 @@ async def create_snapshot_safe(vm_name: str):
"""Wrapper to handle errors for individual VMs."""
try:
result = await handler.create_snapshot(
vm_name=vm_name,
name=snapshot_name,
description=description,
user_id=user_id,
{"vm_name": vm_name, "name": snapshot_name, "description": description},
user_id,
)
return {
"vm_name": vm_name,
Expand Down Expand Up @@ -123,7 +121,8 @@ async def batch_rollback_snapshots(
async def rollback_safe(vm_name: str):
try:
result = await handler.rollback_snapshot(
vm_name=vm_name, name=snapshot_name, user_id=user_id
{"vm_name": vm_name, "name": snapshot_name},
user_id,
)
return {
"vm_name": vm_name,
Expand Down Expand Up @@ -175,7 +174,8 @@ async def batch_remove_snapshots(
async def remove_safe(vm_name: str):
try:
result = await handler.remove_snapshot(
vm_name=vm_name, name=snapshot_name, user_id=user_id
{"vm_name": vm_name, "name": snapshot_name},
user_id,
)
return {"vm_name": vm_name, "status": "success", "result": format_tool_response(result)}
except Exception as e:
Expand Down
7 changes: 4 additions & 3 deletions ludus_mcp/server/tools/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,8 @@ async def snapshot_host(
Snapshot creation result
"""
handler = registry.get_handler("snapshot", SnapshotHandler)
result = await handler.create_snapshot(vm_name, name, description, user_id)
snapshot_config = {"vm_name": vm_name, "name": name, "description": description}
result = await handler.create_snapshot(snapshot_config, user_id)
return format_tool_response(result)

@mcp.tool()
Expand Down Expand Up @@ -363,7 +364,7 @@ async def rollback_snapshot(
Rollback result
"""
handler = registry.get_handler("snapshot", SnapshotHandler)
result = await handler.rollback_snapshot(vm_name, snapshot_name, user_id)
result = await handler.rollback_snapshot({"vm_name": vm_name, "snapshot_name": snapshot_name}, user_id)
return format_tool_response(result)

@mcp.tool()
Expand All @@ -383,7 +384,7 @@ async def remove_snapshot(
Removal result
"""
handler = registry.get_handler("snapshot", SnapshotHandler)
result = await handler.remove_snapshot(vm_name, snapshot_name, user_id)
result = await handler.remove_snapshot({"vm_name": vm_name, "snapshot_name": snapshot_name}, user_id)
return format_tool_response(result)

# ==================== POWER TOOLS ====================
Expand Down