fix: correct snapshot handler argument passing#5
Open
aazamil wants to merge 1 commit intotjnull:mainfrom
Open
Conversation
- snapshot_host and batch_snapshot_hosts were passing vm_name, name, description as separate args to SnapshotHandler.create_snapshot() which expects (snapshot_config: dict, user_id) - Fixed by wrapping args into snapshot_config dict - Same fix applied to rollback_snapshot and remove_snapshot in batch.py - Verified fix working with Claude Desktop + Ludus lab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The snapshot tools (snapshot_host and batch_snapshot_hosts) fail when called through Claude Desktop with these errors:
SnapshotHandler.create_snapshot() got an unexpected keyword argument 'vm_name'SnapshotHandler.create_snapshot() takes from 2 to 3 positional arguments but 5 were givenRoot Cause
In core.py and batch.py, snapshot functions were passing vm_name, name, and description as separate arguments to the handler. But SnapshotHandler.create_snapshot() expects (snapshot_config: dict, user_id).
Fix
Wrapped the arguments into a snapshot_config dict:
Testing
Verified fix working with Claude Desktop + Ludus lab
Closes #4