Skip to content

🛡️ Sentinel: [HIGH] Fix XSS vulnerability in confirm dialog #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thirdeyenation wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🛡️ Sentinel: [HIGH] Fix XSS vulnerability in confirm dialog #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/sentinel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
## 2026-05-17 - Prevent XSS in generic UI components
**Vulnerability:** XSS vulnerability in `showConfirmDialog` via unsafe `innerHTML` interpolation of `title` and `message`.
**Learning:** Generic UI components that accept parameters often construct DOM elements using template literals and `innerHTML`, making them vulnerable if untrusted input is passed.
**Prevention:** Always use `textContent` for text-only inputs, or sanitize HTML inputs using `DOMPurify` (e.g., `sanitizeHtml`) before injecting them into the DOM.
9 changes: 5 additions & 4 deletions webui/js/confirmDialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Custom confirmation dialog. CSS in /css/modals.css

import { callJsExtensions } from "/js/extensions.js";
import { sanitizeHtml } from "/js/safe-markdown.js";

const DIALOG_TYPES = {
warning: { icon: 'warning', color: 'var(--color-warning, #f59e0b)' },
Expand Down Expand Up @@ -31,12 +32,12 @@ export function showConfirmDialog(options) {
dialog.innerHTML = `
<div class="confirm-dialog-header">
<span class="confirm-dialog-icon material-symbols-outlined" style="color: ${typeConfig.color}">${typeConfig.icon}</span>
<span class="confirm-dialog-title">${title}</span>
<span class="confirm-dialog-title">${sanitizeHtml(title)}</span>
</div>
<div class="confirm-dialog-body">${message}</div>
<div class="confirm-dialog-body">${sanitizeHtml(message)}</div>
<div class="confirm-dialog-footer">
<button class="button cancel confirm-dialog-cancel">${cancelText}</button>
<button class="button confirm confirm-dialog-confirm">${confirmText}</button>
<button class="button cancel confirm-dialog-cancel">${sanitizeHtml(cancelText)}</button>
<button class="button confirm confirm-dialog-confirm">${sanitizeHtml(confirmText)}</button>
</div>
`;

Expand Down