π‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in confirm dialog#118
π‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in confirm dialog#118thirdeyenation wants to merge 1 commit into
Conversation
Sanitized the interpolated inputs to dialog.innerHTML using sanitizeHtml. Co-authored-by: thirdeyenation <133812267+thirdeyenation@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: XSS via unsafe
innerHTMLinterpolation inshowConfirmDialogπ― Impact: Malicious scripts could be executed if untrusted input is passed to dialog parameters
π§ Fix: Implemented
sanitizeHtmlto clean the dialog content before DOM injectionβ Verification: Verifiable via static analysis or testing the dialog with malicious input
PR created automatically by Jules for task 8606964549932104885 started by @thirdeyenation