[PR-7] feat: add PySCF validation tests and interactive tutorial notebook#241
Draft
San1357 wants to merge 13 commits intotheochem:masterfrom
Draft
[PR-7] feat: add PySCF validation tests and interactive tutorial notebook#241San1357 wants to merge 13 commits intotheochem:masterfrom
San1357 wants to merge 13 commits intotheochem:masterfrom
Conversation
This was referenced Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/test_pyscf_comparison.py— 15 tests validating both original and improved ERI implementations against PySCF reference valuesnotebooks/tutorial/Tutorial 3 - Two-Electron Integral Optimizations.ipynb— interactive tutorial covering OS+HGP algorithm, Boys functions, Schwarz screening, high angular momentum, and PySCF validationWhat Changed
tests/test_pyscf_comparison.pyTestPySCFOriginal(6),TestPySCFImproved(6),TestPySCFPhysicalProperties(3) — H2/STO-3G, chemist/physicist notation, symmetries, physical propertiesnotebooks/tutorial/Tutorial 3 - Two-Electron Integral Optimizations.ipynbHow To Test
Proof That It Works
- All 15 PySCF tests pass when pyscf is installed (
pip install pyscf)First Checklist
Scope Of this PR
electron_repulsion_integralandelectron_repulsion_integral_improvedagainst PySCFSecond Checklist
Type of Changes